From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.22-rc5] libata: kill the infamous abnormal status message
Date: Wed, 27 Jun 2007 02:45:09 -0400 [thread overview]
Message-ID: <46820775.8030204@garzik.org> (raw)
In-Reply-To: <467FB589.2060900@gmail.com>
Tejun Heo wrote:
> The infamous abnormal status message triggers on not so abnormal cases
> including empty port and even when it's being triggered on actual
> errors the info it provides is redundant and out of context - higher
> level functions will print the info in better safe later anyway.
>
> Also, by being triggered all the time, it leads people to think that
> the abnormality is somehow related to all ATA and system problems
> they're experiencing and gives owners of healthy systems unfounded
> doubts about the integrity of the universe. Make it a DPRINTK and
> save the universe.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> include/linux/libata.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
applied
prev parent reply other threads:[~2007-06-27 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 12:31 [PATCH 2.6.22-rc5] libata: kill the infamous abnormal status message Tejun Heo
2007-06-25 12:42 ` Alan Cox
2007-06-27 6:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46820775.8030204@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).