[PATCH 2.6.22-rc5] libata: kill the infamous abnormal status message

[PATCH 2.6.22-rc5] libata: kill the infamous abnormal status message

[Tejun Heo]

The infamous abnormal status message triggers on not so abnormal cases
including empty port and even when it's being triggered on actual
errors the info it provides is redundant and out of context - higher
level functions will print the info in better safe later anyway.

Also, by being triggered all the time, it leads people to think that
the abnormality is somehow related to all ATA and system problems
they're experiencing and gives owners of healthy systems unfounded
doubts about the integrity of the universe.  Make it a DPRINTK and
save the universe.

Signed-off-by: Tejun Heo <htejun@gmail.com>
---
 include/linux/libata.h |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 745c4f9..a3380f8 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1088,11 +1088,9 @@ static inline u8 ata_wait_idle(struct ata_port *ap)
 {
 	u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000);
 
-	if (status != 0xff && (status & (ATA_BUSY | ATA_DRQ))) {
-		if (ata_msg_warn(ap))
-			printk(KERN_WARNING "ATA: abnormal status 0x%X on port 0x%p\n",
-				status, ap->ioaddr.status_addr);
-	}
+	if (status != 0xff && (status & (ATA_BUSY | ATA_DRQ)))
+		DPRINTK("ATA: abnormal status 0x%X on port 0x%p\n",
+			status, ap->ioaddr.status_addr);
 
 	return status;
 }

Re: [PATCH 2.6.22-rc5] libata: kill the infamous abnormal status message

[Alan Cox]

On Mon, 25 Jun 2007 21:31:05 +0900
Tejun Heo <htejun@gmail.com> wrote:

> The infamous abnormal status message triggers on not so abnormal cases
> including empty port and even when it's being triggered on actual
> errors the info it provides is redundant and out of context - higher
> level functions will print the info in better safe later anyway.
> 
> Also, by being triggered all the time, it leads people to think that
> the abnormality is somehow related to all ATA and system problems
> they're experiencing and gives owners of healthy systems unfounded
> doubts about the integrity of the universe.  Make it a DPRINTK and
> save the universe.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

Acked-by: Alan Cox <alan@redhat.com>

Re: [PATCH 2.6.22-rc5] libata: kill the infamous abnormal status message

[Jeff Garzik]

Tejun Heo wrote:
> The infamous abnormal status message triggers on not so abnormal cases
> including empty port and even when it's being triggered on actual
> errors the info it provides is redundant and out of context - higher
> level functions will print the info in better safe later anyway.
> 
> Also, by being triggered all the time, it leads people to think that
> the abnormality is somehow related to all ATA and system problems
> they're experiencing and gives owners of healthy systems unfounded
> doubts about the integrity of the universe.  Make it a DPRINTK and
> save the universe.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
>  include/linux/libata.h |    8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

applied