From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.22-rc5] libata: remove unused variable from ata_eh_reset()
Date: Wed, 27 Jun 2007 02:45:30 -0400 [thread overview]
Message-ID: <4682078A.7040601@garzik.org> (raw)
In-Reply-To: <467FB858.1060907@gmail.com>
Tejun Heo wrote:
> Removed unused variable did_followup_srst from ata_eh_reset().
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index d807098..48d2d54 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1616,7 +1616,7 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
> unsigned long deadline;
> unsigned int action;
> ata_reset_fn_t reset;
> - int i, did_followup_srst, rc;
> + int i, rc;
>
> /* about to reset */
> ata_eh_about_to_do(ap, NULL, ehc->i.action & ATA_EH_RESET_MASK);
> @@ -1689,11 +1689,9 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
>
> rc = ata_do_reset(ap, reset, classes, deadline);
>
> - did_followup_srst = 0;
> if (reset == hardreset &&
> ata_eh_followup_srst_needed(rc, classify, classes)) {
> /* okay, let's do follow-up softreset */
> - did_followup_srst = 1;
> reset = softreset;
>
applied
prev parent reply other threads:[~2007-06-27 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 12:43 [PATCH 2.6.22-rc5] libata: remove unused variable from ata_eh_reset() Tejun Heo
2007-06-27 6:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4682078A.7040601@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).