* [PATCH 2.6.22-rc5] libata: remove unused variable from ata_eh_reset()
@ 2007-06-25 12:43 Tejun Heo
2007-06-27 6:45 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-06-25 12:43 UTC (permalink / raw)
To: Jeff Garzik, linux-ide@vger.kernel.org
Removed unused variable did_followup_srst from ata_eh_reset().
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-eh.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index d807098..48d2d54 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1616,7 +1616,7 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
unsigned long deadline;
unsigned int action;
ata_reset_fn_t reset;
- int i, did_followup_srst, rc;
+ int i, rc;
/* about to reset */
ata_eh_about_to_do(ap, NULL, ehc->i.action & ATA_EH_RESET_MASK);
@@ -1689,11 +1689,9 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
rc = ata_do_reset(ap, reset, classes, deadline);
- did_followup_srst = 0;
if (reset == hardreset &&
ata_eh_followup_srst_needed(rc, classify, classes)) {
/* okay, let's do follow-up softreset */
- did_followup_srst = 1;
reset = softreset;
if (!reset) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.22-rc5] libata: remove unused variable from ata_eh_reset()
2007-06-25 12:43 [PATCH 2.6.22-rc5] libata: remove unused variable from ata_eh_reset() Tejun Heo
@ 2007-06-27 6:45 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-06-27 6:45 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide@vger.kernel.org
Tejun Heo wrote:
> Removed unused variable did_followup_srst from ata_eh_reset().
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index d807098..48d2d54 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1616,7 +1616,7 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
> unsigned long deadline;
> unsigned int action;
> ata_reset_fn_t reset;
> - int i, did_followup_srst, rc;
> + int i, rc;
>
> /* about to reset */
> ata_eh_about_to_do(ap, NULL, ehc->i.action & ATA_EH_RESET_MASK);
> @@ -1689,11 +1689,9 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
>
> rc = ata_do_reset(ap, reset, classes, deadline);
>
> - did_followup_srst = 0;
> if (reset == hardreset &&
> ata_eh_followup_srst_needed(rc, classify, classes)) {
> /* okay, let's do follow-up softreset */
> - did_followup_srst = 1;
> reset = softreset;
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-27 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-25 12:43 [PATCH 2.6.22-rc5] libata: remove unused variable from ata_eh_reset() Tejun Heo
2007-06-27 6:45 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).