From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.22-rc5] libata: fix ata_dev_disable()
Date: Wed, 27 Jun 2007 02:45:47 -0400 [thread overview]
Message-ID: <4682079B.90005@garzik.org> (raw)
In-Reply-To: <467FD25A.2040606@gmail.com>
Tejun Heo wrote:
> Fix silly condition check bug in ata_dev_disable().
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index adfae9d..09ade2a 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -600,8 +600,9 @@ static const char *sata_spd_string(unsigned int spd)
>
> void ata_dev_disable(struct ata_device *dev)
> {
> - if (ata_dev_enabled(dev) && ata_msg_drv(dev->ap)) {
> - ata_dev_printk(dev, KERN_WARNING, "disabled\n");
> + if (ata_dev_enabled(dev)) {
> + if (ata_msg_drv(dev->ap))
> + ata_dev_printk(dev, KERN_WARNING, "disabled\n");
> ata_down_xfermask_limit(dev, ATA_DNXFER_FORCE_PIO0 |
> ATA_DNXFER_QUIET);
applied
prev parent reply other threads:[~2007-06-27 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 14:34 [PATCH 2.6.22-rc5] libata: fix ata_dev_disable() Tejun Heo
2007-06-27 6:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4682079B.90005@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).