From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.22-rc5] libata: fix infinite EH waiting bug
Date: Wed, 27 Jun 2007 02:45:53 -0400 [thread overview]
Message-ID: <468207A1.6000301@garzik.org> (raw)
In-Reply-To: <467FB94F.1040000@gmail.com>
Tejun Heo wrote:
> When EH gives up after repeated exceptions, it doesn't't clear the
> PENDING bit on exit which leaves PENDING bit set without EH actually
> scheduled. This makes ata_port_wait_eh() to wait forever makes rmmod
> hang on such port. Fix it by clearing the flag.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index d807098..fbdfefb 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -336,6 +336,7 @@ void ata_scsi_error(struct Scsi_Host *host)
> }
> ata_port_printk(ap, KERN_ERR, "EH pending after %d "
> "tries, giving up\n", ATA_EH_MAX_REPEAT);
> + ap->pflags &= ~ATA_PFLAG_EH_PENDING;
> }
>
applied
prev parent reply other threads:[~2007-06-27 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 12:47 [PATCH 2.6.22-rc5] libata: fix infinite EH waiting bug Tejun Heo
2007-06-27 6:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468207A1.6000301@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).