Re: [PATCH 13/15] ide: add ata_set{_max}_pio()

[Jeff Garzik <jeff@garzik.org>]

Bartlomiej Zolnierkiewicz wrote:
> * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags
>   and set them in ht6560, cmd640, cmd64x and sc1200 host drivers.
> 
> * Add set_pio_mode_abuse() for checking if host driver has a non-standard
>   ->tuneproc() implementation and use it in do_special().
> 
> * Add ata_set_pio() for setting PIO mode (it uses hwif->pio_mask to find
>   the maximum PIO mode supported by the host), also add ata_set_max_pio()
>   wrapper for ata_set_pio() to use for auto-tuning.  Convert users of
>   ->tuneproc to use ata_set{_max}_pio() where possible.  This leaves only
>   do_special(), set_using_pio(), ide_hwif_restore() and ata_set_pio() as
>   a direct users of ->tuneproc.
> 
> * Remove no longer needed ide_get_best_pio_mode() calls and printk-s
>   reporting PIO mode selected from ->tuneproc implementations.
> 
> * Rename ->tuneproc hook to ->set_pio_mode and make 'pio' argument const.
> 
> * Remove stale comment from ide_config_drive_speed().
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

It seems highly inconsistent for drivers/ide to use the "ide_" prefix 
the vast majority of the time, but then "ata_" prefix in this one case, 
particularly when libata uses the "ata_" prefix almost exclusively.

	Jeff