From: Jeff Garzik <jeff@garzik.org>
To: albertl@mail.com
Cc: Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.22-rc6] libata: remove reading alt_status from ata_hsm_qc_complete()
Date: Mon, 02 Jul 2007 10:14:29 -0400 [thread overview]
Message-ID: <46890845.8070909@garzik.org> (raw)
In-Reply-To: <4683176B.3060605@tw.ibm.com>
Albert Lee wrote:
> In ata_hsm_qc_complete():
> Calling ata_altstatus() after the qc is completed might race with next qc. Remove it.
>
> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
> ---
> Jeff,
>
> (Sorry for re-submitting this patch so late.)
> The unneeded reading of alt_status might cause trouble when another command doing activity like pio data xfer.
> After checking, the flush here is leftover/merge damage of ata_pio_block( ) in 2.6.17-rc5:
> http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commitdiff;h=bb31a8faa270beafcc51a65880c5564c6b718bd6
> We can safely remove it.
applied
prev parent reply other threads:[~2007-07-02 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 2:05 [PATCH 2.6.22-rc6] libata: remove reading alt_status from ata_hsm_qc_complete() Albert Lee
2007-07-02 14:14 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46890845.8070909@garzik.org \
--to=jeff@garzik.org \
--cc=albertl@mail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).