* [PATCH 2.6.22-rc6] libata: remove reading alt_status from ata_hsm_qc_complete()
@ 2007-06-28 2:05 Albert Lee
2007-07-02 14:14 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Albert Lee @ 2007-06-28 2:05 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux IDE
In ata_hsm_qc_complete():
Calling ata_altstatus() after the qc is completed might race with next qc. Remove it.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
---
Jeff,
(Sorry for re-submitting this patch so late.)
The unneeded reading of alt_status might cause trouble when another command doing activity like pio data xfer.
After checking, the flush here is leftover/merge damage of ata_pio_block( ) in 2.6.17-rc5:
http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commitdiff;h=bb31a8faa270beafcc51a65880c5564c6b718bd6
We can safely remove it.
--- linux-2.6.22-rc6/drivers/ata/libata-core.c.ori 2007-06-28 09:47:31.000000000 +0800
+++ linux-2.6.22-rc6/drivers/ata/libata-core.c 2007-06-28 09:49:26.000000000 +0800
@@ -4799,8 +4799,6 @@ static void ata_hsm_qc_complete(struct a
} else
ata_qc_complete(qc);
}
-
- ata_altstatus(ap); /* flush */
}
/**
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-02 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-28 2:05 [PATCH 2.6.22-rc6] libata: remove reading alt_status from ata_hsm_qc_complete() Albert Lee
2007-07-02 14:14 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).