From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
ide <linux-ide@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Roy Franz <roy.lists@gmail.com>
Subject: Re: [PATCH -mm] sata_nv: allow changing queue depth
Date: Mon, 02 Jul 2007 10:14:50 -0400 [thread overview]
Message-ID: <4689085A.9030005@garzik.org> (raw)
In-Reply-To: <468457C8.7060507@shaw.ca>
Robert Hancock wrote:
> The sata_nv driver was missing the change_queue_depth hook in the SCSI host
> template which the other NCQ-capable libata drivers had. This made it impossible
> to change the queue depth by user request. Add this in.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
>
> --- linux-2.6.22-rc6-mm1/drivers/ata/sata_nv.c 2007-06-28 17:30:28.000000000 -0600
> +++ linux-2.6.22-rc6-mm1edit/drivers/ata/sata_nv.c 2007-06-28 17:39:30.000000000 -0600
> @@ -398,6 +398,7 @@ static struct scsi_host_template nv_adma
> .name = DRV_NAME,
> .ioctl = ata_scsi_ioctl,
> .queuecommand = ata_scsi_queuecmd,
> + .change_queue_depth = ata_scsi_change_queue_depth,
> .can_queue = NV_ADMA_MAX_CPBS,
> .this_id = ATA_SHT_THIS_ID,
> .sg_tablesize = NV_ADMA_SGTBL_TOTAL_LEN,
> @@ -416,6 +417,7 @@ static struct scsi_host_template nv_swnc
> .name = DRV_NAME,
> .ioctl = ata_scsi_ioctl,
> .queuecommand = ata_scsi_queuecmd,
> + .change_queue_depth = ata_scsi_change_queue_depth,
> .can_queue = ATA_MAX_QUEUE,
> .this_id = ATA_SHT_THIS_ID,
> .sg_tablesize = LIBATA_MAX_PRD,
applied manually, patch didn't apply to 2.6.22-rc7
prev parent reply other threads:[~2007-07-02 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 0:52 [PATCH -mm] sata_nv: allow changing queue depth Robert Hancock
2007-07-02 14:14 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4689085A.9030005@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).