* [PATCH -mm] sata_nv: allow changing queue depth
@ 2007-06-29 0:52 Robert Hancock
2007-07-02 14:14 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Robert Hancock @ 2007-06-29 0:52 UTC (permalink / raw)
To: linux-kernel, ide, Andrew Morton; +Cc: Roy Franz
The sata_nv driver was missing the change_queue_depth hook in the SCSI host
template which the other NCQ-capable libata drivers had. This made it impossible
to change the queue depth by user request. Add this in.
Signed-off-by: Robert Hancock <hancockr@shaw.ca>
--- linux-2.6.22-rc6-mm1/drivers/ata/sata_nv.c 2007-06-28 17:30:28.000000000 -0600
+++ linux-2.6.22-rc6-mm1edit/drivers/ata/sata_nv.c 2007-06-28 17:39:30.000000000 -0600
@@ -398,6 +398,7 @@ static struct scsi_host_template nv_adma
.name = DRV_NAME,
.ioctl = ata_scsi_ioctl,
.queuecommand = ata_scsi_queuecmd,
+ .change_queue_depth = ata_scsi_change_queue_depth,
.can_queue = NV_ADMA_MAX_CPBS,
.this_id = ATA_SHT_THIS_ID,
.sg_tablesize = NV_ADMA_SGTBL_TOTAL_LEN,
@@ -416,6 +417,7 @@ static struct scsi_host_template nv_swnc
.name = DRV_NAME,
.ioctl = ata_scsi_ioctl,
.queuecommand = ata_scsi_queuecmd,
+ .change_queue_depth = ata_scsi_change_queue_depth,
.can_queue = ATA_MAX_QUEUE,
.this_id = ATA_SHT_THIS_ID,
.sg_tablesize = LIBATA_MAX_PRD,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -mm] sata_nv: allow changing queue depth
2007-06-29 0:52 [PATCH -mm] sata_nv: allow changing queue depth Robert Hancock
@ 2007-07-02 14:14 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-07-02 14:14 UTC (permalink / raw)
To: Robert Hancock; +Cc: linux-kernel, ide, Andrew Morton, Roy Franz
Robert Hancock wrote:
> The sata_nv driver was missing the change_queue_depth hook in the SCSI host
> template which the other NCQ-capable libata drivers had. This made it impossible
> to change the queue depth by user request. Add this in.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
>
> --- linux-2.6.22-rc6-mm1/drivers/ata/sata_nv.c 2007-06-28 17:30:28.000000000 -0600
> +++ linux-2.6.22-rc6-mm1edit/drivers/ata/sata_nv.c 2007-06-28 17:39:30.000000000 -0600
> @@ -398,6 +398,7 @@ static struct scsi_host_template nv_adma
> .name = DRV_NAME,
> .ioctl = ata_scsi_ioctl,
> .queuecommand = ata_scsi_queuecmd,
> + .change_queue_depth = ata_scsi_change_queue_depth,
> .can_queue = NV_ADMA_MAX_CPBS,
> .this_id = ATA_SHT_THIS_ID,
> .sg_tablesize = NV_ADMA_SGTBL_TOTAL_LEN,
> @@ -416,6 +417,7 @@ static struct scsi_host_template nv_swnc
> .name = DRV_NAME,
> .ioctl = ata_scsi_ioctl,
> .queuecommand = ata_scsi_queuecmd,
> + .change_queue_depth = ata_scsi_change_queue_depth,
> .can_queue = ATA_MAX_QUEUE,
> .this_id = ATA_SHT_THIS_ID,
> .sg_tablesize = LIBATA_MAX_PRD,
applied manually, patch didn't apply to 2.6.22-rc7
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-02 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-29 0:52 [PATCH -mm] sata_nv: allow changing queue depth Robert Hancock
2007-07-02 14:14 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).