linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 7/15] ide: drop "PIO data" argument from ide_get_best_pio_mode()
Date: Mon, 02 Jul 2007 21:41:34 +0400	[thread overview]
Message-ID: <468938CE.8010202@ru.mvista.com> (raw)
In-Reply-To: <200706302105.20596.bzolnier@gmail.com>

Hello.

Bartlomiej Zolnierkiewicz wrote:

> * Drop no longer needed "PIO data" argument from ide_get_best_pio_mode()
>   and convert all users accordingly.

> * Remove no longer needed ide_pio_data_t.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: b/drivers/ide/pci/tc86c001.c
> ===================================================================
> --- a/drivers/ide/pci/tc86c001.c
> +++ b/drivers/ide/pci/tc86c001.c
> @@ -47,7 +47,7 @@ static int tc86c001_tune_chipset(ide_dri
>  
>  static void tc86c001_tune_drive(ide_drive_t *drive, u8 pio)
>  {
> -	pio =  ide_get_best_pio_mode(drive, pio, 4, NULL);
> +	pio = ide_get_best_pio_mode(drive, pio, 4);

    Oh, you've ruined my formatting... :'-[

>  	(void) tc86c001_tune_chipset(drive, XFER_PIO_0 + pio);
>  }
>  

MBR, Sergei

  reply	other threads:[~2007-07-02 17:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-30 19:05 [PATCH 7/15] ide: drop "PIO data" argument from ide_get_best_pio_mode() Bartlomiej Zolnierkiewicz
2007-07-02 17:41 ` Sergei Shtylyov [this message]
2007-07-02 18:14   ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468938CE.8010202@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).