* [PATCH] it821x: fix incorrect SWDMA mask
@ 2007-07-02 23:45 Bartlomiej Zolnierkiewicz
2007-07-03 14:09 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-02 23:45 UTC (permalink / raw)
To: linux-ide
SWDMA modes are unsupported by it821x. Attempts to tune SWDMA modes always
fail (due to sanity check in ->speedproc) and result in PIO being tuned.
* Fix incorrect SWDMA mask so core code won't try these modes and will just
tune PIO if no other DMA modes are available.
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
for 2.6.22-final
drivers/ide/pci/it821x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: b/drivers/ide/pci/it821x.c
===================================================================
--- a/drivers/ide/pci/it821x.c
+++ b/drivers/ide/pci/it821x.c
@@ -1,6 +1,6 @@
/*
- * linux/drivers/ide/pci/it821x.c Version 0.15 Jun 2 2007
+ * linux/drivers/ide/pci/it821x.c Version 0.16 Jul 3 2007
*
* Copyright (C) 2004 Red Hat <alan@redhat.com>
* Copyright (C) 2007 Bartlomiej Zolnierkiewicz
@@ -660,7 +660,6 @@ static void __devinit init_hwif_it821x(i
hwif->ultra_mask = 0x7f;
hwif->mwdma_mask = 0x07;
- hwif->swdma_mask = 0x07;
hwif->ide_dma_check = &it821x_config_drive_for_dma;
if (!(hwif->udma_four))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] it821x: fix incorrect SWDMA mask
2007-07-02 23:45 [PATCH] it821x: fix incorrect SWDMA mask Bartlomiej Zolnierkiewicz
@ 2007-07-03 14:09 ` Sergei Shtylyov
2007-07-03 19:08 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2007-07-03 14:09 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Hello.
Bartlomiej Zolnierkiewicz wrote:
> SWDMA modes are unsupported by it821x. Attempts to tune SWDMA modes always
> fail (due to sanity check in ->speedproc) and result in PIO being tuned.
> * Fix incorrect SWDMA mask so core code won't try these modes and will just
> tune PIO if no other DMA modes are available.
> * Bump driver version.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] it821x: fix incorrect SWDMA mask
2007-07-03 14:09 ` Sergei Shtylyov
@ 2007-07-03 19:08 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-03 19:08 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide
On Tuesday 03 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > SWDMA modes are unsupported by it821x. Attempts to tune SWDMA modes always
> > fail (due to sanity check in ->speedproc) and result in PIO being tuned.
>
> > * Fix incorrect SWDMA mask so core code won't try these modes and will just
> > tune PIO if no other DMA modes are available.
>
> > * Bump driver version.
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-03 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-02 23:45 [PATCH] it821x: fix incorrect SWDMA mask Bartlomiej Zolnierkiewicz
2007-07-03 14:09 ` Sergei Shtylyov
2007-07-03 19:08 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).