From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: htejun@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.22-rc7] sata_sil24: sil24_interrupt() micro-optimisation
Date: Tue, 03 Jul 2007 10:17:31 -0400 [thread overview]
Message-ID: <468A5A7B.4050803@garzik.org> (raw)
In-Reply-To: <200707022310.l62NAPA7007676@harpo.it.uu.se>
Mikael Pettersson wrote:
> sil24_interrupt() loads host->ports[i] into a local variable,
> validates it, and then loads the value again in the call to
> sil24_host_intr(). This patch replaces the second load by a
> reference to the local variable.
>
> This is safe since no side-effects have occurred since the
> initial load. It also improves readability since it makes
> it clear that the parameter to sil24_host_intr() is the same
> value which was just validated.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
applied
prev parent reply other threads:[~2007-07-03 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 23:10 [PATCH 2.6.22-rc7] sata_sil24: sil24_interrupt() micro-optimisation Mikael Pettersson
2007-07-03 14:17 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468A5A7B.4050803@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).