From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, Forrest Zhao <forrest.zhao@gmail.com>
Subject: Re: [PATCH 02/12] libata: implement AC_ERR_NCQ
Date: Tue, 03 Jul 2007 10:24:59 -0400 [thread overview]
Message-ID: <468A5C3B.7040508@garzik.org> (raw)
In-Reply-To: <11832836172598-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> +++ b/include/linux/libata.h
> @@ -322,7 +322,8 @@ enum ata_completion_errors {
> AC_ERR_SYSTEM = (1 << 6), /* system error */
> AC_ERR_INVALID = (1 << 7), /* invalid argument */
> AC_ERR_OTHER = (1 << 8), /* unknown */
> - AC_ERR_NODEV_HINT = (1 << 9), /* polling device detection hint */
> + AC_ERR_NCQ = (1 << 9), /* marker for offending NCQ qc */
> + AC_ERR_NODEV_HINT = (1 << 10), /* polling device detection hint */
patch is OK, except for the above very-minor flaw: to remind, do not
re-arrange bit numbers in the same patch you are adding bits. it makes
the patch more difficult to read. Just add the new bit at the end.
If you wish to re-arrange the bits, do it in a separate patch (though I
see no need for re-arranging)
next prev parent reply other threads:[~2007-07-03 14:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 9:53 [PATCHSET 1/4] libata: misc updates in preparation of PMP support Tejun Heo
2007-07-01 9:53 ` [PATCH 01/12] libata: update EH report formatting Tejun Heo
2007-07-03 14:22 ` Jeff Garzik
2007-07-03 15:02 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 02/12] libata: implement AC_ERR_NCQ Tejun Heo
2007-07-03 14:24 ` Jeff Garzik [this message]
2007-07-03 14:58 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 04/12] ahci: make NO_NCQ handling more consistent Tejun Heo
2007-07-03 14:28 ` Jeff Garzik
2007-07-01 9:53 ` [PATCH 05/12] ahci: implement SCR_NOTIFICATION r/w Tejun Heo
2007-07-03 14:31 ` Jeff Garzik
2007-07-03 15:00 ` Tejun Heo
2007-07-13 11:53 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 03/12] libata: make ->scr_read/write callbacks return error code Tejun Heo
2007-07-03 14:26 ` Jeff Garzik
2007-07-01 9:53 ` [PATCH 11/12] libata: schedule probing after SError access failure during autopsy Tejun Heo
2007-07-03 14:35 ` Jeff Garzik
2007-07-03 15:05 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 08/12] libata: improve SCSI scan failure handling Tejun Heo
2007-07-01 9:53 ` [PATCH 10/12] libata: clear HOTPLUG flag after a reset Tejun Heo
2007-07-03 14:34 ` Jeff Garzik
2007-07-01 9:53 ` [PATCH 06/12] libata: improve SATA PHY speed down logic Tejun Heo
2007-07-01 9:53 ` [PATCH 12/12] libata: implement EH fast drain Tejun Heo
2007-07-03 14:37 ` Jeff Garzik
2007-07-03 15:09 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 09/12] libata: reorganize ata_ehi_hotplugged() Tejun Heo
2007-07-01 9:53 ` [PATCH 07/12] libata: quickly trigger SATA SPD down after debouncing failed Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468A5C3B.7040508@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=forrest.zhao@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).