From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, Forrest Zhao <forrest.zhao@gmail.com>
Subject: Re: [PATCH 01/12] libata: update EH report formatting
Date: Wed, 04 Jul 2007 00:02:55 +0900 [thread overview]
Message-ID: <468A651F.3070306@gmail.com> (raw)
In-Reply-To: <468A5BA8.9070705@garzik.org>
Jeff Garzik wrote:
> Tejun Heo wrote:
>> Update formatting for LLD provided error descriptions such that...
>>
>> * No default () around it
>> * Each element is separated by <> not ,
>>
>> This change makes each element responsible for putting a space after
>> itself instead of before - e.g. "<elem> " not ", elem". This is more
>> conventional and allows more flexible combination of messages.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> either way, it is messy.
>
> I guarantee that programmers are not going to remember always to add a
> "magic space" after certain error descriptions. It is far, far better
> for the upper layer to help out a bit, and insert a space and/or comma
> for the LLDD. After all, the LLDD might not be the only one printing
> error messages at that time; the upper layer might also wish to do so in
> the same dmesg line.
Okay then, I guess it's __ata_ehi_push_desc()/ata_ehi_push_desc() time,
where the prefixed one is the raw one and the latter one is with
automatic "<> " added. Will fix.
--
tejun
next prev parent reply other threads:[~2007-07-03 15:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 9:53 [PATCHSET 1/4] libata: misc updates in preparation of PMP support Tejun Heo
2007-07-01 9:53 ` [PATCH 01/12] libata: update EH report formatting Tejun Heo
2007-07-03 14:22 ` Jeff Garzik
2007-07-03 15:02 ` Tejun Heo [this message]
2007-07-01 9:53 ` [PATCH 02/12] libata: implement AC_ERR_NCQ Tejun Heo
2007-07-03 14:24 ` Jeff Garzik
2007-07-03 14:58 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 04/12] ahci: make NO_NCQ handling more consistent Tejun Heo
2007-07-03 14:28 ` Jeff Garzik
2007-07-01 9:53 ` [PATCH 05/12] ahci: implement SCR_NOTIFICATION r/w Tejun Heo
2007-07-03 14:31 ` Jeff Garzik
2007-07-03 15:00 ` Tejun Heo
2007-07-13 11:53 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 03/12] libata: make ->scr_read/write callbacks return error code Tejun Heo
2007-07-03 14:26 ` Jeff Garzik
2007-07-01 9:53 ` [PATCH 11/12] libata: schedule probing after SError access failure during autopsy Tejun Heo
2007-07-03 14:35 ` Jeff Garzik
2007-07-03 15:05 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 08/12] libata: improve SCSI scan failure handling Tejun Heo
2007-07-01 9:53 ` [PATCH 06/12] libata: improve SATA PHY speed down logic Tejun Heo
2007-07-01 9:53 ` [PATCH 10/12] libata: clear HOTPLUG flag after a reset Tejun Heo
2007-07-03 14:34 ` Jeff Garzik
2007-07-01 9:53 ` [PATCH 09/12] libata: reorganize ata_ehi_hotplugged() Tejun Heo
2007-07-01 9:53 ` [PATCH 12/12] libata: implement EH fast drain Tejun Heo
2007-07-03 14:37 ` Jeff Garzik
2007-07-03 15:09 ` Tejun Heo
2007-07-01 9:53 ` [PATCH 07/12] libata: quickly trigger SATA SPD down after debouncing failed Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468A651F.3070306@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=forrest.zhao@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).