From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.22-rc7 2/3] libata: implement HORKAGE_SETXFER
Date: Thu, 05 Jul 2007 21:22:44 +0900 [thread overview]
Message-ID: <468CE294.2080705@gmail.com> (raw)
In-Reply-To: <20070705132706.743d18d8@the-village.bc.nu>
Alan Cox wrote:
> On Thu, 5 Jul 2007 13:35:01 +0900
> Tejun Heo <htejun@gmail.com> wrote:
>
>> Make CFA SETXFER failure handling into HORKAGE. This will be used to
>> allow other cases to ignore SETXFER failure.
>
> NAK
>
>> + /* Old CFA may refuse SETFEATURES_XFER, which
>> + * is just fine
>> + */
>> + if (!(xfer_mask & ~ATA_MASK_PIO))
>> + dev->horkage |= ATA_HORKAGE_SETXFER;
>> + } else
>
> This is specifically done for PIO. An XFER failure for non PIO modes is a
> serious failure and happens in the real world sometimes.
Hmmm... That's what "if (!(xfer_mask & ~ATA_MASK_PIO))" test was for.
Or is it not enough?
--
tejun
next prev parent reply other threads:[~2007-07-05 12:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 4:31 [PATCH 2.6.22-rc7 1/3] libata: clean up horkage handling Tejun Heo
2007-07-05 4:35 ` [PATCH 2.6.22-rc7 2/3] libata: implement HORKAGE_SETXFER Tejun Heo
2007-07-05 4:39 ` [PATCH 2.6.22-rc7 3/3] libata: pata_via CX700 quirks Tejun Heo
2007-07-05 12:34 ` Alan Cox
2007-07-05 12:39 ` Tejun Heo
2007-07-05 12:27 ` [PATCH 2.6.22-rc7 2/3] libata: implement HORKAGE_SETXFER Alan Cox
2007-07-05 12:22 ` Tejun Heo [this message]
2007-07-05 12:38 ` Alan Cox
2007-07-05 12:28 ` [PATCH 2.6.22-rc7 1/3] libata: clean up horkage handling Alan Cox
2007-07-11 1:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468CE294.2080705@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).