[PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

[PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

[Tejun Heo]

The Zip 250 which chokes on MWDMA SET_XFERMODE sometimes have "Floppy"
appeneded to its model number.  Quirk it too.

  http://bugzilla.kernel.org/show_bug.cgi?id=8563

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Hans de Bruin <bruinjm@xs4all.nl>
---
It seems the Zip 250 mwdma failure on libata doesn't seem to be
libata's fault after all.  IDE also fails SET_XFERMODE on this drive
but IDE simply ignores the error and continues to operate in MWDMA
mode, so I guess we can remove the 'temporary fix' comment or add
another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it.

Anyways, for the time being, this should do.

 drivers/ata/libata-core.c |    2 ++
 1 file changed, 2 insertions(+)

Index: work/drivers/ata/libata-core.c
===================================================================
--- work.orig/drivers/ata/libata-core.c
+++ work/drivers/ata/libata-core.c
@@ -3774,6 +3774,8 @@ static const struct ata_blacklist_entry 
 	{ "SAMSUNG CD-ROM SN-124","N001",	ATA_HORKAGE_NODMA },
 	{ "Seagate STT20000A", NULL,		ATA_HORKAGE_NODMA },
 	{ "IOMEGA  ZIP 250       ATAPI", NULL,	ATA_HORKAGE_NODMA }, /* temporary fix */
+	{ "IOMEGA  ZIP 250       ATAPI       Floppy",
+				NULL,		ATA_HORKAGE_NODMA },
 
 	/* Weird ATAPI devices */
 	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },

Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

[Alan Cox]

> but IDE simply ignores the error and continues to operate in MWDMA
> mode, so I guess we can remove the 'temporary fix' comment or add
> another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it.

Should we warn in these cases ? Or issue a new identify and check the
mode activated ?

Alan

Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

[Jeff Garzik]

Alan Cox wrote:
>> but IDE simply ignores the error and continues to operate in MWDMA
>> mode, so I guess we can remove the 'temporary fix' comment or add
>> another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it.
> 
> Should we warn in these cases ? Or issue a new identify and check the
> mode activated ?

The latter, issuing a new identify, is really what you want to do. 
AFAICT that's the canonical method of querying the device's knowledge of 
its mode settings.

	Jeff

Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

[Tejun Heo]

Jeff Garzik wrote:
> Alan Cox wrote:
>>> but IDE simply ignores the error and continues to operate in MWDMA
>>> mode, so I guess we can remove the 'temporary fix' comment or add
>>> another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it.
>>
>> Should we warn in these cases ? Or issue a new identify and check the
>> mode activated ?
> 
> The latter, issuing a new identify, is really what you want to do.
> AFAICT that's the canonical method of querying the device's knowledge of
> its mode settings.

How about just keep using PIO as the patch posted in this thread does?
I'm not really sure adding more complexity is worth it considering it's
only one device till now and it may not even be safe considering that
some controllers snoop SETXFER and configure themselves accordingly.

-- 
tejun

Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

[Jeff Garzik]

Tejun Heo wrote:
> The Zip 250 which chokes on MWDMA SET_XFERMODE sometimes have "Floppy"
> appeneded to its model number.  Quirk it too.
> 
>   http://bugzilla.kernel.org/show_bug.cgi?id=8563
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Hans de Bruin <bruinjm@xs4all.nl>
> ---
> It seems the Zip 250 mwdma failure on libata doesn't seem to be
> libata's fault after all.  IDE also fails SET_XFERMODE on this drive
> but IDE simply ignores the error and continues to operate in MWDMA
> mode, so I guess we can remove the 'temporary fix' comment or add
> another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it.
> 
> Anyways, for the time being, this should do.
> 
>  drivers/ata/libata-core.c |    2 ++
>  1 file changed, 2 insertions(+)

applied