From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, bruinjm@xs4all.nl
Subject: Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY
Date: Fri, 06 Jul 2007 15:42:50 +0900 [thread overview]
Message-ID: <468DE46A.6080908@gmail.com> (raw)
In-Reply-To: <468D8482.9040203@garzik.org>
Jeff Garzik wrote:
> Alan Cox wrote:
>>> but IDE simply ignores the error and continues to operate in MWDMA
>>> mode, so I guess we can remove the 'temporary fix' comment or add
>>> another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it.
>>
>> Should we warn in these cases ? Or issue a new identify and check the
>> mode activated ?
>
> The latter, issuing a new identify, is really what you want to do.
> AFAICT that's the canonical method of querying the device's knowledge of
> its mode settings.
How about just keep using PIO as the patch posted in this thread does?
I'm not really sure adding more complexity is worth it considering it's
only one device till now and it may not even be safe considering that
some controllers snoop SETXFER and configure themselves accordingly.
--
tejun
next prev parent reply other threads:[~2007-07-06 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 3:31 [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY Tejun Heo
2007-07-05 12:39 ` Alan Cox
2007-07-05 23:53 ` Jeff Garzik
2007-07-06 6:42 ` Tejun Heo [this message]
2007-07-11 1:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468DE46A.6080908@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bruinjm@xs4all.nl \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).