From: Albert Lee <albertcc@tw.ibm.com>
To: Tejun Heo <htejun@gmail.com>
Cc: albertl@mail.com, Jeff Garzik <jeff@garzik.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux IDE <linux-ide@vger.kernel.org>,
Mark Lord <mlord@pobox.com>
Subject: Re: [PATCH 0/10] libata: irq_on/off restructuring
Date: Fri, 06 Jul 2007 17:23:25 +0800 [thread overview]
Message-ID: <468E0A0D.3030303@tw.ibm.com> (raw)
In-Reply-To: <468CCC82.6050008@gmail.com>
Tejun Heo wrote:
>
> I like the whole series. Just a few nits.
>
> * 9 and 10 need to be oen patch. As it currently stands, compile will
> fail after 9.
>
> * Please don't include "Patch n/10" in message body.
>
> * Add freeze/thaw to all, merge, kill freeze/thaw from all sequence is a
> bit odd. It would be better if we can do things more directly but I
> haven't thought about how that can be done too hard, so if it's too
> difficult, it's probably not worth it.
>
> Alan, Jeff, I think we'll need to do what IDE has been doing for IRQ
> masking to get acceptable PIO behavior after all and that will also make
> us more resistant against deadly IRQ storms on controllers which don't
> have pending IRQ bits (most SFF ones), and this change will ease our way
> toward that direction. What do you guys think?
>
Thanks for the review/advice. Revised patches to follow.
--
albert
prev parent reply other threads:[~2007-07-06 9:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 8:38 [PATCH 0/10] libata: irq_on/off restructuring Albert Lee
2007-07-04 8:43 ` [PATCH 1/10] libata: remove irq_on from ata_bus_reset() and ata_std_postreset() Albert Lee
2007-07-05 10:18 ` Tejun Heo
2007-07-04 8:46 ` [PATCH 2/10] libata: add irq_off Albert Lee
2007-07-04 8:49 ` [PATCH 3/10] libata: implement ->irq_off in LLDDs Albert Lee
2007-07-04 8:52 ` [PATCH 4/10] libata: call irq_off from bmdma_freeze() Albert Lee
2007-07-04 8:57 ` [PATCH 5/10] libata: use freeze/thaw for polling Albert Lee
2007-07-04 8:59 ` [PATCH 6/10] libata: add freeze/thaw to old EH LLDDs Albert Lee
2007-07-04 9:01 ` [PATCH 7/10] libata: pdc_freeze() semantic change Albert Lee
2007-07-04 9:03 ` [PATCH 8/10] libata: remove writing of tf->ctl from ata_tf_load() Albert Lee
2007-07-04 19:09 ` Mark Lord
2007-07-05 2:43 ` Albert Lee
2007-07-05 10:40 ` Tejun Heo
2007-07-04 9:16 ` [PATCH 9/10] libata: Integrate freeze/thaw with irq_on/off Albert Lee
2007-07-04 9:29 ` [PATCH 10/10] libata: Integrate freeze/thaw with irq_on/off in LLDDs Albert Lee
2007-07-05 10:48 ` [PATCH 0/10] libata: irq_on/off restructuring Tejun Heo
2007-07-06 9:23 ` Albert Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468E0A0D.3030303@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).