From: Jeff Garzik <jeff@garzik.org>
To: Kuan Luo <kluo@nvidia.com>,
hancockr@shaw.ca, Peer Chen <pchen@nvidia.com>,
Allen Martin <AMartin@nvidia.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-ide@vger.kernel.org
Subject: Disabling ADMA? (was Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61)
Date: Sat, 07 Jul 2007 11:39:17 -0400 [thread overview]
Message-ID: <468FB3A5.9000008@garzik.org> (raw)
In-Reply-To: <15F501D1A78BD343BE8F4D8DB854566B059FE131@hkemmail01.nvidia.com>
Kuan Luo wrote:
> @@ -1714,3 +2761,6 @@ module_init(nv_init);
> module_exit(nv_exit);
> module_param_named(adma, adma_enabled, bool, 0444);
> MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: true)");
> +module_param_named(ncq, ncq_enabled, bool, 0444);
> +MODULE_PARM_DESC(ncq, "Enable use of NCQ (Default: false)");
After looking through sata_nv bug reports, I am leaning towards
disabling ADMA by default, and wanted to solicit comments.
While admittedly not knowing the root cause, it seems like every current
outstanding sata_nv bug report that remains after switching out hardware
can be solved by setting module option 'adma' to zero. That's my first
suggestion upon any bugzilla sata_nv bug, and it usually works. You can
look through bugs assigned to or CC'd to jgarzik@pobox.com (kernel.org
bugs) jgarzik@redhat.com (redhat.com bugs) for examples.
I still need to review the SWNCQ patch in detail, but I presume it is
possible to still use SWNCQ without ADMA?
On a side note, I would rather default SWNCQ to 'on'.
Jeff
next prev parent reply other threads:[~2007-07-07 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 11:10 [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61 Kuan Luo
2007-07-07 15:39 ` Jeff Garzik [this message]
2007-07-07 17:57 ` Disabling ADMA? (was Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61) Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468FB3A5.9000008@garzik.org \
--to=jeff@garzik.org \
--cc=AMartin@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=hancockr@shaw.ca \
--cc=kluo@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).