From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Fajun Chen <fajunchen@gmail.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: Question about PATA Sil680 Bus Reset Code
Date: Tue, 10 Jul 2007 16:58:16 +0400 [thread overview]
Message-ID: <46938268.4070209@ru.mvista.com> (raw)
In-Reply-To: <20070709230908.08f5c8d8@the-village.bc.nu>
Alan Cox wrote:
>> I guess it's been blindly copied over form drivers/ide/pci/siimage.c...
Yet the order of events between IDE and libata drivers is different:
the old driver's resetproc() method is called just after the twiddling the bit
on/off, the new driver calls ata_std_softreset() after the PCI config.
register manipulation. However, since all it does is set 2 read-only bits, it
should make no difference...
>>The code indeed does seem meaningless. For the libata it could make sense to
>>set bit 2 for the hardreset -- but then sil680_error_handler() needs to be
>>turn into ata_bmdma_drive_eh(ap, ata_std_prereset, ata_std_softreset,
>>sil680_bus_reset, ata_std_postreset)...
>> For the legacy driver, this function needs to be converted to something
>>sane too...
> I think the evidence based upon years of highly reliable siimage usage is
> that its simply not needed 8)
I would think so as well but was not sure about the SStatus reg. read at
the end of it...
MBR, Sergei
next prev parent reply other threads:[~2007-07-10 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 16:46 Question about PATA Sil680 Bus Reset Code Fajun Chen
2007-07-09 16:58 ` Jeff Garzik
2007-07-09 18:37 ` Sergei Shtylyov
2007-07-09 18:46 ` Jeff Garzik
2007-07-09 18:51 ` Sergei Shtylyov
2007-07-09 22:09 ` Alan Cox
2007-07-10 12:58 ` Sergei Shtylyov [this message]
2007-07-10 22:00 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46938268.4070209@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=fajunchen@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).