From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2.6.22-rc7 1/3] libata: clean up horkage handling
Date: Tue, 10 Jul 2007 21:38:19 -0400 [thread overview]
Message-ID: <4694348B.5020408@garzik.org> (raw)
In-Reply-To: <20070705043127.GX29122@htj.dyndns.org>
Tejun Heo wrote:
> Horkage handling had the following problems.
>
> * dev->horkage was positioned after ATA_DEVICE_CLEAR_OFFSET, so it was
> cleared before the device is configured. This broke
> HORKAGE_DIAGNOSTIC.
>
> * Some used dev->horkage while others called ata_device_blacklisted()
> directly. This was at best confusing.
>
> This patch moves dev->horkage right after dev->flags and set the field
> according to the blacklist during device configuration. All users
> test against dev->horkage. ata_device_blacklisted() now has only one
> user, make it static. While at it, rename it to ata_dev_blacklisted()
> for consistency.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-core.c | 13 ++++++++-----
> include/linux/libata.h | 3 +--
> 2 files changed, 9 insertions(+), 7 deletions(-)
applied
prev parent reply other threads:[~2007-07-11 1:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 4:31 [PATCH 2.6.22-rc7 1/3] libata: clean up horkage handling Tejun Heo
2007-07-05 4:35 ` [PATCH 2.6.22-rc7 2/3] libata: implement HORKAGE_SETXFER Tejun Heo
2007-07-05 4:39 ` [PATCH 2.6.22-rc7 3/3] libata: pata_via CX700 quirks Tejun Heo
2007-07-05 12:34 ` Alan Cox
2007-07-05 12:39 ` Tejun Heo
2007-07-05 12:27 ` [PATCH 2.6.22-rc7 2/3] libata: implement HORKAGE_SETXFER Alan Cox
2007-07-05 12:22 ` Tejun Heo
2007-07-05 12:38 ` Alan Cox
2007-07-05 12:28 ` [PATCH 2.6.22-rc7 1/3] libata: clean up horkage handling Alan Cox
2007-07-11 1:38 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4694348B.5020408@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).