From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, Forrest Zhao <forrest.zhao@gmail.com>
Subject: Re: [PATCH 14/16] libata-link: update EH to deal with PMP links
Date: Tue, 10 Jul 2007 21:54:41 -0400 [thread overview]
Message-ID: <46943861.2000104@garzik.org> (raw)
In-Reply-To: <11832843614018-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> Update ata_eh_autopsy(), ata_eh_report(),
> ata_eh_revalidate_and_attach() and ata_eh_recover() to deal with PMP
> links. ata_eh_autopsy() and ata_eh_report() updates are
> straightforward. They just repeat the same operation over all
> configured links. The only change to ata_eh_revalidate_and_attach()
> is avoiding calling ->cable_select() on non-host ports.
>
> ata_eh_recover() update is more complex as it first processes all
> resets and then performs the rest. This is necessary as thawing with
> some links in unknown state can be dangerous. ehi->action is cleared
> on successful recovery of a link to avoid repeating recovery due to
> failures in other links.
>
> ata_eh_recover() iterates over only PMP links if PMP is attached, and,
> on failure, the failing link is returned in @failed_link instead of
> disabling devices directly. These are to integrate ata_eh_recover()
> into PMP EH later.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
ACK 11-14
next prev parent reply other threads:[~2007-07-11 1:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 10:05 [PATCHSET 2/4] libata: implement ata_link, take 4 Tejun Heo
2007-07-01 10:05 ` [PATCH 01/16] libata-link: separate out ata_eh_handle_dev_fail() Tejun Heo
2007-07-11 1:47 ` Jeff Garzik
2007-07-01 10:05 ` [PATCH 02/16] libata-link: add PMP related ATA constants Tejun Heo
2007-07-01 10:05 ` [PATCH 07/16] libata-link: linkify reset Tejun Heo
2007-07-01 10:05 ` [PATCH 05/16] libata-link: linkify PHY-related functions Tejun Heo
2007-07-01 10:05 ` [PATCH 04/16] libata-link: implement and use link/device iterators Tejun Heo
2007-07-01 10:05 ` [PATCH 03/16] libata-link: introduce ata_link Tejun Heo
2007-07-01 10:05 ` [PATCH 06/16] libata-link: linkify EH action helpers Tejun Heo
2007-07-01 10:06 ` [PATCH 09/16] libata-link: make two port flags HRST_TO_RESUME and SKIP_D2H_BSY link flags Tejun Heo
2007-07-01 10:06 ` [PATCH 08/16] libata-link: linkify config/EH related functions Tejun Heo
2007-07-01 10:06 ` [PATCH 12/16] libata-link: add PMP links Tejun Heo
2007-07-01 10:06 ` [PATCH 10/16] libata-link: separate out link initialization functions Tejun Heo
2007-07-11 1:52 ` Jeff Garzik
2007-07-01 10:06 ` [PATCH 11/16] libata-link: implement ata_link_abort() Tejun Heo
2007-07-01 10:06 ` [PATCH 13/16] libata-link: update ata_scsi_error() to handle PMP links Tejun Heo
2007-07-01 10:06 ` [PATCH 14/16] libata-link: update EH to deal with " Tejun Heo
2007-07-11 1:54 ` Jeff Garzik [this message]
2007-07-01 10:06 ` [PATCH 15/16] libata-link: update hotplug to handle " Tejun Heo
2007-07-11 1:59 ` Jeff Garzik
2007-07-11 2:45 ` Tejun Heo
2007-07-01 10:06 ` [PATCH 16/16] libata-link: update Power Management " Tejun Heo
2007-07-11 1:59 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46943861.2000104@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=forrest.zhao@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).