* invalid map value
@ 2007-07-08 9:28 buthysia
2007-07-10 8:58 ` [PATCH] ata_piix: kill incorrect invalid map value warning Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: buthysia @ 2007-07-08 9:28 UTC (permalink / raw)
To: linux-ide
Hello Jeff,
is correct this email address??!(linux-ide@vger.kernel.org)
My problem:
ata_piix 0000:00:1f.2: MAP [ P0 P2 XX XX ]
ata_piix 0000:
00:1f.2: invalid MAP value 0
Controller:
00:1f.2 IDE interface: Intel
Corporation 82801GBM/GHM (ICH7 Family)
SATA IDE Controller (rev 02)
(prog-if 8f [Master SecP SecO PriP PriO])
Subsystem: Sony Corporation
Unknown device 81ef
Flags: bus master, 66MHz, medium devsel, latency 0,
IRQ 21
I/O ports at 18c8 [size=8]
I/O ports at 18ac [size=4]
I/O ports
at 18c0 [size=8]
I/O ports at 18a8 [size=4]
I/O ports at 18b0 [size=16]
Memory at d2304400 (32-bit, non-prefetchable) [size=1K]
Capabilities:
[70] Power Management version 2
the notebook is a sony vaio fe-21m
with hd FUJITSU MHV2160B.
kernel:Linux version 2.6.20-gentoo-r8
compiled with gcc version 4.1.2.
Is it a serious problem?!?...is there
a workaround to fix this?!
Sorry for my english!
Regards!
Daniele.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ata_piix: kill incorrect invalid map value warning
2007-07-08 9:28 invalid map value buthysia
@ 2007-07-10 8:58 ` Tejun Heo
2007-07-12 20:10 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2007-07-10 8:58 UTC (permalink / raw)
To: jeff, buthysia@virgilio.it; +Cc: linux-ide
The last two slots of MAP 00b of ich6m was incorrectly marked as
reserved. This is left over from converting the entry to allow 00b.
This causes no real problem. It only makes the driver print annoying
warning message. Fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
--
drivers/ata/ata_piix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 6a3bfef..21a7ca4 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -414,7 +414,7 @@ static const struct piix_map_db ich6m_map_db = {
*/
.map = {
/* PM PS SM SS MAP */
- { P0, P2, RV, RV }, /* 00b */
+ { P0, P2, NA, NA }, /* 00b */
{ IDE, IDE, P1, P3 }, /* 01b */
{ P0, P2, IDE, IDE }, /* 10b */
{ RV, RV, RV, RV },
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ata_piix: kill incorrect invalid map value warning
2007-07-10 8:58 ` [PATCH] ata_piix: kill incorrect invalid map value warning Tejun Heo
@ 2007-07-12 20:10 ` Jeff Garzik
2007-07-13 3:01 ` Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-07-12 20:10 UTC (permalink / raw)
To: Tejun Heo; +Cc: buthysia@virgilio.it, linux-ide, tardyp
Tejun Heo wrote:
> The last two slots of MAP 00b of ich6m was incorrectly marked as
> reserved. This is left over from converting the entry to allow 00b.
> This causes no real problem. It only makes the driver print annoying
> warning message. Fix it.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> --
> drivers/ata/ata_piix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index 6a3bfef..21a7ca4 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -414,7 +414,7 @@ static const struct piix_map_db ich6m_map_db = {
> */
> .map = {
> /* PM PS SM SS MAP */
> - { P0, P2, RV, RV }, /* 00b */
> + { P0, P2, NA, NA }, /* 00b */
> { IDE, IDE, P1, P3 }, /* 01b */
> { P0, P2, IDE, IDE }, /* 10b */
> { RV, RV, RV, RV },
applied (with credit also to Pierre Tardy for spotting this as well)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ata_piix: kill incorrect invalid map value warning
2007-07-12 20:10 ` Jeff Garzik
@ 2007-07-13 3:01 ` Tejun Heo
0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2007-07-13 3:01 UTC (permalink / raw)
To: Jeff Garzik; +Cc: buthysia@virgilio.it, linux-ide, tardyp
Jeff Garzik wrote:
> Tejun Heo wrote:
>> The last two slots of MAP 00b of ich6m was incorrectly marked as
>> reserved. This is left over from converting the entry to allow 00b.
>> This causes no real problem. It only makes the driver print annoying
>> warning message. Fix it.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> --
>> drivers/ata/ata_piix.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
>> index 6a3bfef..21a7ca4 100644
>> --- a/drivers/ata/ata_piix.c
>> +++ b/drivers/ata/ata_piix.c
>> @@ -414,7 +414,7 @@ static const struct piix_map_db ich6m_map_db = {
>> */
>> .map = {
>> /* PM PS SM SS MAP */
>> - { P0, P2, RV, RV }, /* 00b */
>> + { P0, P2, NA, NA }, /* 00b */
>> { IDE, IDE, P1, P3 }, /* 01b */
>> { P0, P2, IDE, IDE }, /* 10b */
>> { RV, RV, RV, RV },
>
> applied (with credit also to Pierre Tardy for spotting this as well)
>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-13 3:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-08 9:28 invalid map value buthysia
2007-07-10 8:58 ` [PATCH] ata_piix: kill incorrect invalid map value warning Tejun Heo
2007-07-12 20:10 ` Jeff Garzik
2007-07-13 3:01 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).