From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] ata_piix: kill incorrect invalid map value warning Date: Fri, 13 Jul 2007 12:01:40 +0900 Message-ID: <4696EB14.7010304@gmail.com> References: <113a52882e6.buthysia@virgilio.it> <20070710085821.GC23568@htj.dyndns.org> <46968AA6.7000404@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from nz-out-0506.google.com ([64.233.162.229]:38468 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754732AbXGMDBr (ORCPT ); Thu, 12 Jul 2007 23:01:47 -0400 Received: by nz-out-0506.google.com with SMTP id s18so324989nze for ; Thu, 12 Jul 2007 20:01:45 -0700 (PDT) In-Reply-To: <46968AA6.7000404@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: "buthysia@virgilio.it" , linux-ide@vger.kernel.org, tardyp@gmail.com Jeff Garzik wrote: > Tejun Heo wrote: >> The last two slots of MAP 00b of ich6m was incorrectly marked as >> reserved. This is left over from converting the entry to allow 00b. >> This causes no real problem. It only makes the driver print annoying >> warning message. Fix it. >> >> Signed-off-by: Tejun Heo >> -- >> drivers/ata/ata_piix.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c >> index 6a3bfef..21a7ca4 100644 >> --- a/drivers/ata/ata_piix.c >> +++ b/drivers/ata/ata_piix.c >> @@ -414,7 +414,7 @@ static const struct piix_map_db ich6m_map_db = { >> */ >> .map = { >> /* PM PS SM SS MAP */ >> - { P0, P2, RV, RV }, /* 00b */ >> + { P0, P2, NA, NA }, /* 00b */ >> { IDE, IDE, P1, P3 }, /* 01b */ >> { P0, P2, IDE, IDE }, /* 10b */ >> { RV, RV, RV, RV }, > > applied (with credit also to Pierre Tardy for spotting this as well) > Thanks. -- tejun