From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Jeremy Higdon <jeremy@sgi.com>
Subject: Re: [PATCH 5/6] sgiioc4: use ide_tune_dma()
Date: Fri, 13 Jul 2007 19:25:19 +0400 [thread overview]
Message-ID: <4697995F.6070004@ru.mvista.com> (raw)
In-Reply-To: <200707110206.07157.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> * Add DRV_NAME define and use it instead of sgiioc4_chipset.name.
> * Remove no longer needed sgiioc4_chipset.
> * Remove needless clearing of ->atapi_dma from ide_dma_sgiioc4().
> * Fix ide_dma_sgiioc4() to return success/failure. Check return value in
> sgiioc4_ide_setup_pci_device() and set hwif->autodma accordingly. Also add
> missing setting of drive->autodma.
> * Add sgiioc4_speedproc() (implementation of ->speedproc method).
> * Fix ->mwdma_mask (MWDMA2 mask is 0x04 not 0x02) and remove incorrect
> ->swdma_mask. Also remove needless initialization of ->ultra_mask.
> * Use ide_tune_dma() in sgiioc4_ide_dma_check(), this fixes following bugs:
> - DMA capability bit not being checked on the device
> - DMA blacklist not being checked
> - MWDMA2 mode support by device not being checked
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Nice cleanups...
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
next prev parent reply other threads:[~2007-07-13 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 0:06 [PATCH 5/6] sgiioc4: use ide_tune_dma() Bartlomiej Zolnierkiewicz
2007-07-13 15:25 ` Sergei Shtylyov [this message]
2007-07-13 19:49 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4697995F.6070004@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=jeremy@sgi.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).