* [PATCH 4/6] amd74xx/via82cxxx: use ide_tune_dma()
@ 2007-07-11 0:04 Bartlomiej Zolnierkiewicz
2007-07-13 16:57 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-11 0:04 UTC (permalink / raw)
To: linux-ide
* Use ide_tune_dma() in amd74xx/via82cxxx driver, this fixes following bugs:
- DMA capability bit not being checked on the device
- DMA blacklist not being checked
- DMA mode being programmed even if drive->autodma == 0
(thus possibly destroying PIO timings)
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/pci/amd74xx.c | 15 ++++-----------
drivers/ide/pci/via82cxxx.c | 15 ++++-----------
2 files changed, 8 insertions(+), 22 deletions(-)
Index: b/drivers/ide/pci/amd74xx.c
===================================================================
--- a/drivers/ide/pci/amd74xx.c
+++ b/drivers/ide/pci/amd74xx.c
@@ -1,5 +1,5 @@
/*
- * Version 2.21
+ * Version 2.22
*
* AMD 755/756/766/8111 and nVidia nForce/2/2s/3/3s/CK804/MCP04
* IDE driver for Linux.
@@ -277,18 +277,11 @@ static void amd_set_pio_mode(ide_drive_t
static int amd74xx_ide_dma_check(ide_drive_t *drive)
{
- u8 speed = ide_max_dma_mode(drive);
-
- if (speed == 0) {
- ide_set_max_pio(drive);
- return -1;
- }
-
- amd_set_drive(drive, speed);
-
- if (drive->autodma)
+ if (ide_tune_dma(drive))
return 0;
+ ide_set_max_pio(drive);
+
return -1;
}
Index: b/drivers/ide/pci/via82cxxx.c
===================================================================
--- a/drivers/ide/pci/via82cxxx.c
+++ b/drivers/ide/pci/via82cxxx.c
@@ -1,6 +1,6 @@
/*
*
- * Version 3.46
+ * Version 3.47
*
* VIA IDE driver for Linux. Supported southbridges:
*
@@ -217,18 +217,11 @@ static void via_set_pio_mode(ide_drive_t
static int via82cxxx_ide_dma_check (ide_drive_t *drive)
{
- u8 speed = ide_max_dma_mode(drive);
-
- if (speed == 0) {
- ide_set_max_pio(drive);
- return -1;
- }
-
- via_set_drive(drive, speed);
-
- if (drive->autodma)
+ if (ide_tune_dma(drive))
return 0;
+ ide_set_max_pio(drive);
+
return -1;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 4/6] amd74xx/via82cxxx: use ide_tune_dma()
2007-07-11 0:04 [PATCH 4/6] amd74xx/via82cxxx: use ide_tune_dma() Bartlomiej Zolnierkiewicz
@ 2007-07-13 16:57 ` Sergei Shtylyov
2007-07-13 20:03 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2007-07-13 16:57 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> * Use ide_tune_dma() in amd74xx/via82cxxx driver, this fixes following bugs:
> - DMA capability bit not being checked on the device
> - DMA blacklist not being checked
> - DMA mode being programmed even if drive->autodma == 0
> (thus possibly destroying PIO timings)
> * Bump driver version.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 4/6] amd74xx/via82cxxx: use ide_tune_dma()
2007-07-13 16:57 ` Sergei Shtylyov
@ 2007-07-13 20:03 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-13 20:03 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide
On Friday 13 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Use ide_tune_dma() in amd74xx/via82cxxx driver, this fixes following bugs:
> > - DMA capability bit not being checked on the device
> > - DMA blacklist not being checked
> > - DMA mode being programmed even if drive->autodma == 0
> > (thus possibly destroying PIO timings)
>
> > * Bump driver version.
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-13 21:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-11 0:04 [PATCH 4/6] amd74xx/via82cxxx: use ide_tune_dma() Bartlomiej Zolnierkiewicz
2007-07-13 16:57 ` Sergei Shtylyov
2007-07-13 20:03 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).