From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Kyle McMartin <kyle@mcmartin.ca>
Subject: Re: [PATCH 3/6] ide-pmac: PIO fixes
Date: Sat, 14 Jul 2007 20:29:10 +0400 [thread overview]
Message-ID: <4698F9D6.6020205@ru.mvista.com> (raw)
In-Reply-To: <200707132203.16470.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
>>>* Add setting transfer mode on the device to pmac_ide_set_pio_mode().
>>>* Fix pmac_ide_set_pio() to always program chipset for given PIO timing instead
>>> of only when the device we want to program PIO timing for is the currently
>>> selected one.
>> Hm, why this was necessary?
> No idea...
I may understand why this was needed beore the patch but why keep it?
> ...(mis)optimization? :)
>> AFAIU, pmac_ide_do_setfeature() will cause selectproc() to be called
>>anyway, via SELECT_DRIVE()...
> Yes, but pmac_ide_do_setfeature() wasn't called et all in the old version
> of pmac_ide_set_pio().
But now it is.
>>>* Now that pmac_ide_set_pio() is fixed there is no need to set transfer mode
>>> on the device and program chipset for PIO in pmac_ide_tune_chipset()
>> BTW, I'm also not seeing much sense in calling
>>pmac_ide_do_update_timings() from there as well since pmac_ide_do_setfeature()
>>is called before that anyway.
> The patch only intended to make pmac_ide_set_pio() match the code in
> pmac_ide_tune_chipset(). Thanks to your analysis I see now that more
> fixups/cleanups are possible in this driver but I'm not up to it...
:-)
MBR, Sergei
prev parent reply other threads:[~2007-07-14 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 0:04 [PATCH 3/6] ide-pmac: PIO fixes Bartlomiej Zolnierkiewicz
2007-07-12 19:33 ` Bartlomiej Zolnierkiewicz
2007-07-13 0:52 ` Benjamin Herrenschmidt
2007-07-13 16:12 ` Sergei Shtylyov
2007-07-13 20:03 ` Bartlomiej Zolnierkiewicz
2007-07-14 16:29 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4698F9D6.6020205@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=kyle@mcmartin.ca \
--cc=linux-ide@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).