From: Tejun Heo <htejun@gmail.com>
To: Petr Vandrovec <petr@vandrovec.name>
Cc: Ryan Power <rpower@sysreset.com>,
Robert Hancock <hancockr@shaw.ca>,
linux-ide@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
Albert Lee <albertcc@tw.ibm.com>
Subject: Re: [PATCH] Unbreak build of PMP with ACPI disabled
Date: Mon, 16 Jul 2007 19:32:57 +0900 [thread overview]
Message-ID: <469B4959.8010109@gmail.com> (raw)
In-Reply-To: <4698BE05.2080003@vandrovec.name>
[cc'ing Jeff and Albert]
Petr Vandrovec wrote:
> Fix reported task file values in sense data
>
> ata_tf_read was setting HOB bit when lba48 command was submitted, but
> was not clearing it before reading "normal" data. Maybe it would be
> better to just clear HOB bit immediately after reading upper halves
> for lba48 command, but I just decided to clear HOB bit in each
> ata_tf_read...
>
> Signed-off-by: Petr Vandrovec <petr@vandrovec.name>
Acked-by: Tejun Heo <htejun@gmail.com>
Gee, thanks a lot for spotting this. This is definitely for -stable.
Hmm... it's a separate issue and not your fault but ap->last_ctl caching
is broken in the function. Albert is about to remove ap->last_ctl
caching but we still need to fix it for -stable. Petr, are you
interested in submitting a separate patch for fixing ap->last_ctl
handling in the function?
Thanks.
--
tejun
next prev parent reply other threads:[~2007-07-16 10:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 6:56 [PATCH] Unbreak build of PMP with ACPI disabled Petr Vandrovec
2007-07-13 7:09 ` Tejun Heo
2007-07-13 23:30 ` Robert Hancock
2007-07-14 0:00 ` Ryan Power
2007-07-14 2:31 ` Tejun Heo
2007-07-14 12:13 ` Petr Vandrovec
2007-07-16 3:38 ` Ryan Power
2007-07-16 10:32 ` Tejun Heo [this message]
2007-07-17 10:54 ` [PATCH] Fix SMART reporting on 2.6.22 Petr Vandrovec
2007-07-18 3:08 ` Tejun Heo
2007-07-20 11:44 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469B4959.8010109@gmail.com \
--to=htejun@gmail.com \
--cc=albertcc@tw.ibm.com \
--cc=hancockr@shaw.ca \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=petr@vandrovec.name \
--cc=rpower@sysreset.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).