From: Tejun Heo <htejun@gmail.com>
To: Petr Vandrovec <petr@vandrovec.name>
Cc: Ryan Power <rpower@sysreset.com>,
Robert Hancock <hancockr@shaw.ca>,
linux-ide@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
Albert Lee <albertcc@tw.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix SMART reporting on 2.6.22
Date: Wed, 18 Jul 2007 12:08:32 +0900 [thread overview]
Message-ID: <469D8430.10509@gmail.com> (raw)
In-Reply-To: <20070717105459.GA15382@vana.vc.cvut.cz>
> Fix reported task file values in sense data
>
> ata_tf_read was setting HOB bit when lba48 command was submitted, but
> was not clearing it before reading "normal" data. As it is only place
> which sets HOB bit in control register, and register reads should not
> be affected by other bits, let's just clear it when we are done with
> reading upper bytes so non-48bit commands do not have to touch ctl
> at all.
>
> pata_scc suffered from same problem...
>
> Signed-off-by: Petr Vandrovec <petr@vandrovec.name>
Acked-by: Tejun Heo <htejun@gmail.com>
--
tejun
next prev parent reply other threads:[~2007-07-18 3:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 6:56 [PATCH] Unbreak build of PMP with ACPI disabled Petr Vandrovec
2007-07-13 7:09 ` Tejun Heo
2007-07-13 23:30 ` Robert Hancock
2007-07-14 0:00 ` Ryan Power
2007-07-14 2:31 ` Tejun Heo
2007-07-14 12:13 ` Petr Vandrovec
2007-07-16 3:38 ` Ryan Power
2007-07-16 10:32 ` Tejun Heo
2007-07-17 10:54 ` [PATCH] Fix SMART reporting on 2.6.22 Petr Vandrovec
2007-07-18 3:08 ` Tejun Heo [this message]
2007-07-20 11:44 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469D8430.10509@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=albertcc@tw.ibm.com \
--cc=hancockr@shaw.ca \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=petr@vandrovec.name \
--cc=rpower@sysreset.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).