From: Jeff Garzik <jeff@garzik.org>
To: Greg KH <gregkh@suse.de>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
chas@cmf.nrl.navy.mil, rolandd@cisco.com, dwmw2@infradead.org
Subject: Re: [git patches 1/2] warnings: attack valid cases spotted by warnings
Date: Wed, 18 Jul 2007 16:03:05 -0400 [thread overview]
Message-ID: <469E71F9.5000005@garzik.org> (raw)
In-Reply-To: <20070718024637.GC6146@suse.de>
Greg KH wrote:
> On Tue, Jul 17, 2007 at 05:42:39PM -0400, Jeff Garzik wrote:
>> commit ae97fec3701a559929c3529e35417fab133a4d39
>> Author: Jeff Garzik <jeff@garzik.org>
>> Date: Tue Jul 17 01:08:29 2007 -0400
>>
>> drivers/usb/misc/auerswald: fix status check, remove redundant check
>>
>> 1) We should only set 'actual_length' output variable if usb length is
>> known to be good.
>>
>> 2) No need to check actual_length for NULL. The only caller always
>> passes non-NULL value.
>>
>> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>
> I have no objection to this patch at all, however it does not remove the
> compiler warning :(
The description doesn't say it removes a warning, so it doesn't :)
You want to look at
drivers/*: mark variables with uninitialized_var()
which was in posting "[git patches 2/2] warnings: use
uninitialized_var()" and is now upstream commit
a6343afb6e16b65b9f0b264f94f8207212e7e3ae
Jeff
next prev parent reply other threads:[~2007-07-18 20:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 21:42 [git patches 1/2] warnings: attack valid cases spotted by warnings Jeff Garzik
2007-07-17 21:49 ` [git patches 2/2] warnings: use uninitialized_var() Jeff Garzik
2007-07-18 11:30 ` Adrian Bunk
2007-07-17 21:53 ` [git patches 1/2] warnings: attack valid cases spotted by warnings Roland Dreier
2007-07-17 22:10 ` Jeff Garzik
2007-07-17 22:17 ` Jeff Garzik
2007-07-18 2:35 ` Roland Dreier
2007-07-18 2:46 ` Roland Dreier
2007-07-18 4:00 ` Linus Torvalds
2007-07-18 4:18 ` Roland Dreier
2007-07-18 5:12 ` Linus Torvalds
2007-07-18 17:37 ` Roland Dreier
2007-07-18 18:02 ` Linus Torvalds
2007-07-18 2:56 ` Linus Torvalds
2007-07-18 3:09 ` Roland Dreier
2007-07-18 3:29 ` Jeff Garzik
2007-07-17 22:19 ` Andrew Morton
2007-07-17 22:25 ` Linus Torvalds
2007-07-18 2:46 ` Greg KH
2007-07-18 20:03 ` Jeff Garzik [this message]
2007-07-18 22:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469E71F9.5000005@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=dwmw2@infradead.org \
--cc=gregkh@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).