From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [git patches 1/2] warnings: attack valid cases spotted by warnings Date: Wed, 18 Jul 2007 16:03:05 -0400 Message-ID: <469E71F9.5000005@garzik.org> References: <20070717214239.GF28448@devserv.devel.redhat.com> <20070718024637.GC6146@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:60217 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933598AbXGRUDL (ORCPT ); Wed, 18 Jul 2007 16:03:11 -0400 In-Reply-To: <20070718024637.GC6146@suse.de> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Greg KH Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, chas@cmf.nrl.navy.mil, rolandd@cisco.com, dwmw2@infradead.org Greg KH wrote: > On Tue, Jul 17, 2007 at 05:42:39PM -0400, Jeff Garzik wrote: >> commit ae97fec3701a559929c3529e35417fab133a4d39 >> Author: Jeff Garzik >> Date: Tue Jul 17 01:08:29 2007 -0400 >> >> drivers/usb/misc/auerswald: fix status check, remove redundant check >> >> 1) We should only set 'actual_length' output variable if usb length is >> known to be good. >> >> 2) No need to check actual_length for NULL. The only caller always >> passes non-NULL value. >> >> Signed-off-by: Jeff Garzik > > I have no objection to this patch at all, however it does not remove the > compiler warning :( The description doesn't say it removes a warning, so it doesn't :) You want to look at drivers/*: mark variables with uninitialized_var() which was in posting "[git patches 2/2] warnings: use uninitialized_var()" and is now upstream commit a6343afb6e16b65b9f0b264f94f8207212e7e3ae Jeff