* [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()
@ 2007-07-22 18:33 Bartlomiej Zolnierkiewicz
2007-07-22 19:25 ` Sergei Shtylyov
2007-07-22 22:03 ` Benjamin Herrenschmidt
0 siblings, 2 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-22 18:33 UTC (permalink / raw)
To: linux-ide; +Cc: Benjamin Herrenschmidt
Upper layers are responsible for controlling nIEN so don't clear nIEN after
command execution in pmac_ide_do_setfeature().
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ppc/pmac.c | 1 -
1 file changed, 1 deletion(-)
Index: b/drivers/ide/ppc/pmac.c
===================================================================
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -555,7 +555,6 @@ pmac_ide_do_setfeature(ide_drive_t *driv
result = __ide_wait_stat(drive, drive->ready_stat,
BUSY_STAT|DRQ_STAT|ERR_STAT,
WAIT_CMD, &stat);
- hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
if (result)
printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready "
"after SET_FEATURE !\n", drive->name);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()
2007-07-22 18:33 [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature() Bartlomiej Zolnierkiewicz
@ 2007-07-22 19:25 ` Sergei Shtylyov
2007-07-23 21:22 ` Bartlomiej Zolnierkiewicz
2007-07-22 22:03 ` Benjamin Herrenschmidt
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2007-07-22 19:25 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, Benjamin Herrenschmidt
Bartlomiej Zolnierkiewicz wrote:
> Upper layers are responsible for controlling nIEN so don't clear nIEN after
> command execution in pmac_ide_do_setfeature().
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()
2007-07-22 19:25 ` Sergei Shtylyov
@ 2007-07-23 21:22 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-23 21:22 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, Benjamin Herrenschmidt
On Sunday 22 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Upper layers are responsible for controlling nIEN so don't clear nIEN after
> > command execution in pmac_ide_do_setfeature().
>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()
2007-07-22 18:33 [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature() Bartlomiej Zolnierkiewicz
2007-07-22 19:25 ` Sergei Shtylyov
@ 2007-07-22 22:03 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2007-07-22 22:03 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
On Sun, 2007-07-22 at 20:33 +0200, Bartlomiej Zolnierkiewicz wrote:
> Upper layers are responsible for controlling nIEN so don't clear nIEN after
> command execution in pmac_ide_do_setfeature().
Same comment as before regarding the weirdo drive in the wallstreet. I
need to do some tests.
Ben.
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ide/ppc/pmac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: b/drivers/ide/ppc/pmac.c
> ===================================================================
> --- a/drivers/ide/ppc/pmac.c
> +++ b/drivers/ide/ppc/pmac.c
> @@ -555,7 +555,6 @@ pmac_ide_do_setfeature(ide_drive_t *driv
> result = __ide_wait_stat(drive, drive->ready_stat,
> BUSY_STAT|DRQ_STAT|ERR_STAT,
> WAIT_CMD, &stat);
> - hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
> if (result)
> printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready "
> "after SET_FEATURE !\n", drive->name);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-23 21:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-22 18:33 [PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature() Bartlomiej Zolnierkiewicz
2007-07-22 19:25 ` Sergei Shtylyov
2007-07-23 21:22 ` Bartlomiej Zolnierkiewicz
2007-07-22 22:03 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).