From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: greg@kroah.com, linux-ide@vger.kernel.org,
owner-linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops
Date: Tue, 24 Jul 2007 16:59:46 -0400 [thread overview]
Message-ID: <46A66842.6040803@garzik.org> (raw)
In-Reply-To: <20070710065543.GA23568@htj.dyndns.org>
Tejun Heo wrote:
> + /* Some braindamaged ACPI suspend implementations expect the
> + * controller to be awake on entry; otherwise, it burns cpu
> + * cycles and power trying to do something to the sleeping
> + * beauty.
> + */
applied 1-2... HOWEVER...
I would not classify this as braindead. I have applied these patches,
but it must be emphasized that this is a temporary fix only.
Overall, it is unfortunately but libata must be aware of the state the
controller should be in, for suspend and resume. I bet some more
suspend/resume problems can be isolated to a hardware state mismatch,
where BIOS expects one thing but Linux has configured the hardware
differently.
A more generalized rule to consider for the future would be to ensure
that ALL suspend routines put the hardware back into its pre-Linux init
mode before suspending. i.e. that means if we turned on some enhanced
mode, we must switch back to legacy mode before calling pci_xxx to
suspend our device.
Jeff
next prev parent reply other threads:[~2007-07-24 20:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 6:36 [PATCH 1/2] PCI: export __pci_reenable_device() Tejun Heo
2007-07-10 6:55 ` [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops Tejun Heo
2007-07-24 20:59 ` Jeff Garzik [this message]
2007-07-24 21:57 ` Alan Cox
2007-07-24 22:05 ` Jeff Garzik
2007-07-27 5:43 ` [PATCH] pci: rename __pci_reenable_device() to pci_reenable_device() Tejun Heo
2007-07-27 5:53 ` [PATCH] ata_piix: implement piix_borken_suspend() Tejun Heo
2007-07-27 5:55 ` [PATCH] ata_piix: add Tecra M3 to broken suspend blacklist Tejun Heo
2007-07-27 6:22 ` [PATCH] pci: rename __pci_reenable_device() to pci_reenable_device() Greg KH
2007-08-01 14:02 ` Jeff Garzik
2007-07-10 16:17 ` [PATCH 1/2] PCI: export __pci_reenable_device() Greg KH
2007-07-11 10:32 ` [PATCH 1/2] PCI: rename and " Tejun Heo
2007-07-11 10:32 ` [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops Tejun Heo
2007-07-17 17:05 ` [PATCH 1/2] PCI: rename and export __pci_reenable_device() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A66842.6040803@garzik.org \
--to=jeff@garzik.org \
--cc=greg@kroah.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=owner-linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).