linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] pata_cmd64x: Correct the speed ranges
Date: Thu, 26 Jul 2007 21:52:20 +0400	[thread overview]
Message-ID: <46A8DF54.9040201@ru.mvista.com> (raw)
In-Reply-To: <20070726184301.4677ee46@the-village.bc.nu>

Hello.

Alan Cox wrote:

> I must have been half asleep when doing the original code

> Signed-off-by: Alan Cox <alan@redhat.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c linux-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c
> --- linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c	2007-07-26 15:01:52.915752536 +0100
> +++ linux-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c	2007-07-26 15:18:38.486882488 +0100
[...]
> @@ -397,7 +397,7 @@
>  			.flags = ATA_FLAG_SLAVE_POSS,
>  			.pio_mask = 0x1f,
>  			.mwdma_mask = 0x07,

    Note that MWDMA programming is still borken in the libata driver (fixed 
now in the IDE driver).

> -			.udma_mask = ATA_UDMA1,
> +			.udma_mask = ATA_UDMA2,
>  			.port_ops = &cmd64x_port_ops
>  		},
>  		{	/* CMD 646 rev 1  */

MBR, Sergei

  reply	other threads:[~2007-07-26 17:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26 17:43 [PATCH] pata_cmd64x: Correct the speed ranges Alan Cox
2007-07-26 17:52 ` Sergei Shtylyov [this message]
2007-08-01 14:01 ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2007-07-26 21:01 Mikael Pettersson
2007-07-26 21:16 ` Sergei Shtylyov
2007-07-26 22:06   ` Jeff Garzik
2007-07-27 12:29     ` Sergei Shtylyov
2007-07-27 12:40       ` Jeff Garzik
2007-07-27 12:44         ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A8DF54.9040201@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).