* [PATCH] pata_cmd64x: Correct the speed ranges
@ 2007-07-26 17:43 Alan Cox
2007-07-26 17:52 ` Sergei Shtylyov
2007-08-01 14:01 ` Jeff Garzik
0 siblings, 2 replies; 9+ messages in thread
From: Alan Cox @ 2007-07-26 17:43 UTC (permalink / raw)
To: akpm, linux-ide, jeff
I must have been half asleep when doing the original code
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c linux-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c
--- linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c 2007-07-26 15:01:52.915752536 +0100
+++ linux-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c 2007-07-26 15:18:38.486882488 +0100
@@ -31,7 +31,7 @@
#include <linux/libata.h>
#define DRV_NAME "pata_cmd64x"
-#define DRV_VERSION "0.2.3"
+#define DRV_VERSION "0.2.4"
/*
* CMD64x specific registers definition.
@@ -397,7 +397,7 @@
.flags = ATA_FLAG_SLAVE_POSS,
.pio_mask = 0x1f,
.mwdma_mask = 0x07,
- .udma_mask = ATA_UDMA1,
+ .udma_mask = ATA_UDMA2,
.port_ops = &cmd64x_port_ops
},
{ /* CMD 646 rev 1 */
@@ -412,7 +412,7 @@
.flags = ATA_FLAG_SLAVE_POSS,
.pio_mask = 0x1f,
.mwdma_mask = 0x07,
- .udma_mask = ATA_UDMA2,
+ .udma_mask = ATA_UDMA4,
.port_ops = &cmd648_port_ops
},
{ /* CMD 649 */
@@ -420,7 +420,7 @@
.flags = ATA_FLAG_SLAVE_POSS,
.pio_mask = 0x1f,
.mwdma_mask = 0x07,
- .udma_mask = ATA_UDMA3,
+ .udma_mask = ATA_UDMA5,
.port_ops = &cmd648_port_ops
}
};
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] pata_cmd64x: Correct the speed ranges
2007-07-26 17:43 [PATCH] pata_cmd64x: Correct the speed ranges Alan Cox
@ 2007-07-26 17:52 ` Sergei Shtylyov
2007-08-01 14:01 ` Jeff Garzik
1 sibling, 0 replies; 9+ messages in thread
From: Sergei Shtylyov @ 2007-07-26 17:52 UTC (permalink / raw)
To: Alan Cox; +Cc: akpm, linux-ide, jeff
Hello.
Alan Cox wrote:
> I must have been half asleep when doing the original code
> Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c linux-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c
> --- linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c 2007-07-26 15:01:52.915752536 +0100
> +++ linux-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c 2007-07-26 15:18:38.486882488 +0100
[...]
> @@ -397,7 +397,7 @@
> .flags = ATA_FLAG_SLAVE_POSS,
> .pio_mask = 0x1f,
> .mwdma_mask = 0x07,
Note that MWDMA programming is still borken in the libata driver (fixed
now in the IDE driver).
> - .udma_mask = ATA_UDMA1,
> + .udma_mask = ATA_UDMA2,
> .port_ops = &cmd64x_port_ops
> },
> { /* CMD 646 rev 1 */
MBR, Sergei
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] pata_cmd64x: Correct the speed ranges
2007-07-26 17:43 [PATCH] pata_cmd64x: Correct the speed ranges Alan Cox
2007-07-26 17:52 ` Sergei Shtylyov
@ 2007-08-01 14:01 ` Jeff Garzik
1 sibling, 0 replies; 9+ messages in thread
From: Jeff Garzik @ 2007-08-01 14:01 UTC (permalink / raw)
To: Alan Cox; +Cc: akpm, linux-ide
Alan Cox wrote:
> I must have been half asleep when doing the original code
>
> Signed-off-by: Alan Cox <alan@redhat.com>
applied to #upstream-fixes
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pata_cmd64x: Correct the speed ranges
@ 2007-07-26 21:01 Mikael Pettersson
2007-07-26 21:16 ` Sergei Shtylyov
0 siblings, 1 reply; 9+ messages in thread
From: Mikael Pettersson @ 2007-07-26 21:01 UTC (permalink / raw)
To: alan; +Cc: linux-ide
On Thu, 26 Jul 2007 18:43:01 +0100, Alan Cox wrote:
> I must have been half asleep when doing the original code
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
[patch to fix .udma_mask in pata_cmd64x omitted]
This fix inspired me to finally try to convert my Sun Ultra5
(sparc64) with a CMD646 [1095:0646 rev 03] to libata.
With pata_cmd64x the machine has so far survived a usual
boot/mrproper/reconfig/make/install/reboot kernel update
cycle without any issues, and performance seems to be the
same as with the old IDE driver.
/Mikael
scsi0 : pata_cmd64x
scsi1 : pata_cmd64x
ata1: PATA max MWDMA2 cmd 0x000001fe02c00000 ctl 0x000001fe02c0000a bmdma 0x000001fe02c00020 irq 14
ata2: PATA max MWDMA2 cmd 0x000001fe02c00010 ctl 0x000001fe02c0001a bmdma 0x000001fe02c00028 irq 14
ata1.00: ATA-4: ST320420A, 3.21, max UDMA/66
ata1.00: 39851760 sectors, multi 0: LBA
pata_cmd64x: active 3 recovery 1 setup 1.
ata1.00: configured for MWDMA2
ata2.00: ATAPI: CRD-8483B, 1.00, max UDMA/33
pata_cmd64x: active 3 recovery 1 setup 1.
ata2.00: configured for MWDMA2
scsi 0:0:0:0: Direct-Access ATA ST320420A 3.21 PQ: 0 ANSI: 5
sd 0:0:0:0: [sda] 39851760 512-byte hardware sectors (20404 MB)
sd 0:0:0:0: [sda] Write Protect is off
sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
sd 0:0:0:0: [sda] 39851760 512-byte hardware sectors (20404 MB)
sd 0:0:0:0: [sda] Write Protect is off
sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
sda: sda1 sda2 sda3 sda4 sda5
sd 0:0:0:0: [sda] Attached SCSI disk
scsi 1:0:0:0: CD-ROM LG CD-ROM CRD-8483B 1.00 PQ: 0 ANSI: 5
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pata_cmd64x: Correct the speed ranges
2007-07-26 21:01 Mikael Pettersson
@ 2007-07-26 21:16 ` Sergei Shtylyov
2007-07-26 22:06 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: Sergei Shtylyov @ 2007-07-26 21:16 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: alan, linux-ide
Mikael Pettersson wrote:
> This fix inspired me to finally try to convert my Sun Ultra5
> (sparc64) with a CMD646 [1095:0646 rev 03] to libata.
> With pata_cmd64x the machine has so far survived a usual
> boot/mrproper/reconfig/make/install/reboot kernel update
> cycle without any issues, and performance seems to be the
> same as with the old IDE driver.
> /Mikael
>
> scsi0 : pata_cmd64x
> scsi1 : pata_cmd64x
> ata1: PATA max MWDMA2 cmd 0x000001fe02c00000 ctl 0x000001fe02c0000a bmdma 0x000001fe02c00020 irq 14
> ata2: PATA max MWDMA2 cmd 0x000001fe02c00010 ctl 0x000001fe02c0001a bmdma 0x000001fe02c00028 irq 14
> ata1.00: ATA-4: ST320420A, 3.21, max UDMA/66
> ata1.00: 39851760 sectors, multi 0: LBA
> pata_cmd64x: active 3 recovery 1 setup 1.
> ata1.00: configured for MWDMA2
> ata2.00: ATAPI: CRD-8483B, 1.00, max UDMA/33
> pata_cmd64x: active 3 recovery 1 setup 1.
> ata2.00: configured for MWDMA2
[...]
Note that the olde driver has MWDMA fixed, and the new one has it still
borken, yet MWDMA2 is the mode you're using.
MBR, Sergei
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] pata_cmd64x: Correct the speed ranges
2007-07-26 21:16 ` Sergei Shtylyov
@ 2007-07-26 22:06 ` Jeff Garzik
2007-07-27 12:29 ` Sergei Shtylyov
0 siblings, 1 reply; 9+ messages in thread
From: Jeff Garzik @ 2007-07-26 22:06 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Mikael Pettersson, alan, linux-ide
Sergei Shtylyov wrote:
> Note that the olde driver has MWDMA fixed, and the new one has it
> still borken, yet MWDMA2 is the mode you're using.
What about MWDMA is broken?
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pata_cmd64x: Correct the speed ranges
2007-07-26 22:06 ` Jeff Garzik
@ 2007-07-27 12:29 ` Sergei Shtylyov
2007-07-27 12:40 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: Sergei Shtylyov @ 2007-07-27 12:29 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Mikael Pettersson, alan, linux-ide
Hello.
Jeff Garzik wrote:
>> Note that the olde driver has MWDMA fixed, and the new one has it
>> still borken, yet MWDMA2 is the mode you're using.
> What about MWDMA is broken?
The code that "sets" MWDMA timings is completely bogus -- I've already
reported that before. And now I've fixed this in the old IDE driver at last.
> Jeff
MBR, Sergei
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] pata_cmd64x: Correct the speed ranges
2007-07-27 12:29 ` Sergei Shtylyov
@ 2007-07-27 12:40 ` Jeff Garzik
2007-07-27 12:44 ` Sergei Shtylyov
0 siblings, 1 reply; 9+ messages in thread
From: Jeff Garzik @ 2007-07-27 12:40 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Mikael Pettersson, alan, linux-ide
Sergei Shtylyov wrote:
> Hello.
>
> Jeff Garzik wrote:
>
>>> Note that the olde driver has MWDMA fixed, and the new one has it
>>> still borken, yet MWDMA2 is the mode you're using.
>
>> What about MWDMA is broken?
>
> The code that "sets" MWDMA timings is completely bogus -- I've
> already reported that before. And now I've fixed this in the old IDE
> driver at last.
In what way is it completely bogus?
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pata_cmd64x: Correct the speed ranges
2007-07-27 12:40 ` Jeff Garzik
@ 2007-07-27 12:44 ` Sergei Shtylyov
0 siblings, 0 replies; 9+ messages in thread
From: Sergei Shtylyov @ 2007-07-27 12:44 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Mikael Pettersson, alan, linux-ide
Hello.
Jeff Garzik wrote:
>>>> Note that the olde driver has MWDMA fixed, and the new one has it
>>>> still borken, yet MWDMA2 is the mode you're using.
>>> What about MWDMA is broken?
>> The code that "sets" MWDMA timings is completely bogus -- I've
>> already reported that before. And now I've fixed this in the old IDE
>> driver at last.
> In what way is it completely bogus?
It writes these "timings" (they are incorrect too) to the BMIDE status
reg. Bogus enough? ;-)
> Jeff
MBR, Sergei
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2007-08-01 14:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-26 17:43 [PATCH] pata_cmd64x: Correct the speed ranges Alan Cox
2007-07-26 17:52 ` Sergei Shtylyov
2007-08-01 14:01 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-07-26 21:01 Mikael Pettersson
2007-07-26 21:16 ` Sergei Shtylyov
2007-07-26 22:06 ` Jeff Garzik
2007-07-27 12:29 ` Sergei Shtylyov
2007-07-27 12:40 ` Jeff Garzik
2007-07-27 12:44 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).