* [PATCH] pdc202xx_new: check ide_config_drive_speed() return value
@ 2007-07-26 19:56 Bartlomiej Zolnierkiewicz
2007-07-26 20:20 ` Sergei Shtylyov
2007-07-29 10:34 ` Sergei Shtylyov
0 siblings, 2 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-26 19:56 UTC (permalink / raw)
To: linux-ide
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/pci/pdc202xx_new.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: b/drivers/ide/pci/pdc202xx_new.c
===================================================================
--- a/drivers/ide/pci/pdc202xx_new.c
+++ b/drivers/ide/pci/pdc202xx_new.c
@@ -150,13 +150,13 @@ static int pdcnew_tune_chipset(ide_drive
{
ide_hwif_t *hwif = HWIF(drive);
u8 adj = (drive->dn & 1) ? 0x08 : 0x00;
- int err;
/*
* Issue SETFEATURES_XFER to the drive first. PDC202xx hardware will
* automatically set the timing registers based on 100 MHz PLL output.
*/
- err = ide_config_drive_speed(drive, speed);
+ if (ide_config_drive_speed(drive, speed))
+ return 1;
/*
* As we set up the PLL to output 133 MHz for UltraDMA/133 capable
@@ -212,7 +212,7 @@ static int pdcnew_tune_chipset(ide_drive
set_indexed_reg(hwif, 0x10 + adj, tmp & 0x7f);
}
- return err;
+ return 0;
}
static void pdcnew_set_pio_mode(ide_drive_t *drive, const u8 pio)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value
2007-07-26 19:56 [PATCH] pdc202xx_new: check ide_config_drive_speed() return value Bartlomiej Zolnierkiewicz
@ 2007-07-26 20:20 ` Sergei Shtylyov
2007-07-28 21:57 ` Bartlomiej Zolnierkiewicz
2007-07-29 10:34 ` Sergei Shtylyov
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2007-07-26 20:20 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value
2007-07-26 20:20 ` Sergei Shtylyov
@ 2007-07-28 21:57 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-28 21:57 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide
On Thursday 26 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value
2007-07-26 19:56 [PATCH] pdc202xx_new: check ide_config_drive_speed() return value Bartlomiej Zolnierkiewicz
2007-07-26 20:20 ` Sergei Shtylyov
@ 2007-07-29 10:34 ` Sergei Shtylyov
2007-07-29 10:37 ` Sergei Shtylyov
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2007-07-29 10:34 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value
2007-07-29 10:34 ` Sergei Shtylyov
@ 2007-07-29 10:37 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2007-07-29 10:37 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Bartlomiej Zolnierkiewicz, linux-ide
Hello, I wrote:
>> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Oh, sorry for the dupe ack's... :-<
I'd just noticed that I didn't ack the amd74xx patch, so thought I hadn't
ack'ed all the series.
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-07-29 10:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-26 19:56 [PATCH] pdc202xx_new: check ide_config_drive_speed() return value Bartlomiej Zolnierkiewicz
2007-07-26 20:20 ` Sergei Shtylyov
2007-07-28 21:57 ` Bartlomiej Zolnierkiewicz
2007-07-29 10:34 ` Sergei Shtylyov
2007-07-29 10:37 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).