* [PATCH -mm] Fix libata warnings with CONFIG_PM=n
[not found] <20070725040304.111550f4.akpm@linux-foundation.org>
@ 2007-07-28 19:32 ` Gabriel C
2007-07-29 14:58 ` [-mm patch] make scsi_host_link_pm_policy() static Adrian Bunk
1 sibling, 0 replies; 2+ messages in thread
From: Gabriel C @ 2007-07-28 19:32 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, jgarzik, linux-ide
Hi Jeff,
I noticed this warnings when CONFIG_PM=n
...
drivers/ata/libata-core.c:5993: warning: 'ata_host_disable_link_pm' defined but not used
drivers/ata/libata-core.c:6004: warning: 'ata_host_enable_link_pm' defined but not used
...
Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
---
--- linux-2.6.23-rc1/drivers/ata/libata-core.c.orig 2007-07-28 21:17:31.000000000 +0200
+++ linux-2.6.23-rc1/drivers/ata/libata-core.c 2007-07-28 21:17:48.000000000 +0200
@@ -5989,6 +5989,7 @@ int ata_flush_cache(struct ata_device *d
return 0;
}
+#ifdef CONFIG_PM
static void ata_host_disable_link_pm(struct ata_host *host)
{
int i;
@@ -6011,7 +6012,7 @@ static void ata_host_enable_link_pm(stru
}
}
-#ifdef CONFIG_PM
+
static int ata_host_request_pm(struct ata_host *host, pm_message_t mesg,
unsigned int action, unsigned int ehi_flags,
int wait)
^ permalink raw reply [flat|nested] 2+ messages in thread* [-mm patch] make scsi_host_link_pm_policy() static
[not found] <20070725040304.111550f4.akpm@linux-foundation.org>
2007-07-28 19:32 ` [PATCH -mm] Fix libata warnings with CONFIG_PM=n Gabriel C
@ 2007-07-29 14:58 ` Adrian Bunk
1 sibling, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2007-07-29 14:58 UTC (permalink / raw)
To: Andrew Morton, Kristen Carlson Accardi, James Bottomley,
Jeff Garzik
Cc: linux-kernel, linux-ide, linux-scsi
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +ata-ahci-alpm-expose-power-management-policy-option-to-users.patch
>...
> ata things
>...
scsi_host_link_pm_policy() can become static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
--- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_sysfs.c.old 2007-07-26 21:31:24.000000000 +0200
+++ linux-2.6.23-rc1-mm1/drivers/scsi/scsi_sysfs.c 2007-07-26 21:31:57.000000000 +0200
@@ -200,7 +200,7 @@
{ SHOST_MEDIUM_POWER, "medium_power" },
};
-const char *scsi_host_link_pm_policy(enum scsi_host_link_pm policy)
+static const char *scsi_host_link_pm_policy(enum scsi_host_link_pm policy)
{
int i;
char *name = NULL;
^ permalink raw reply [flat|nested] 2+ messages in thread