From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH libata-dev#upstream] libata: implement and use ata_port_desc() to report port configuration
Date: Mon, 30 Jul 2007 00:03:09 +0900 [thread overview]
Message-ID: <46ACAC2D.8050307@gmail.com> (raw)
In-Reply-To: <20070729143106.446924ba@the-village.bc.nu>
Hello, Alan.
Alan Cox wrote:
>> How about this? It's much more flexible and drivers like ahci and
>> sil24 can report something which make sense.
>
> Looks as sane an approach. Some obvious errors in the conversion but
> simply wrong types I/O v MMIO etc not flaws in the proposal
Care to point out?
> Unfortunately there is one big horror you've left unconverted - the status
> address printing in ata_wait_... That is why I ended up going the way I
> did.
The only thing I can find is DPRINTK in ata_wait_idle() which can and
should simply be converted to ata_port_printk("abnormal Status 0x%x\n",
status). After all some controller don't even have Status register (FIS
based ones, ahci, sil24).
Thanks.
--
tejun
next prev parent reply other threads:[~2007-07-29 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 10:34 [PATCH libata-dev#upstream] libata: implement and use ata_port_desc() to report port configuration Tejun Heo
2007-07-29 13:31 ` Alan Cox
2007-07-29 15:03 ` Tejun Heo [this message]
2007-07-29 17:55 ` Alan Cox
2007-07-30 4:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ACAC2D.8050307@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).