From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/11] ide-pmac: don't check kauai_lookup_timing() return value
Date: Sun, 29 Jul 2007 21:26:05 +0400 [thread overview]
Message-ID: <46ACCDAD.1000302@ru.mvista.com> (raw)
In-Reply-To: <1185141244.5439.58.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
>>kauai_lookup_timing() should always return non-zero return value:
>>* BUG() in kauai_lookup_timing() if the timing info cannot be found.
>>* Remove code checking for zero return value from all callers.
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-07-29 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 18:20 [PATCH 1/11] ide-pmac: don't check kauai_lookup_timing() return value Bartlomiej Zolnierkiewicz
2007-07-22 21:54 ` Benjamin Herrenschmidt
2007-07-23 21:21 ` Bartlomiej Zolnierkiewicz
2007-07-29 17:26 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ACCDAD.1000302@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).