Re: [PATCH libata-dev#upstream] libata: implement and use ata_port_desc() to report port configuration

[Tejun Heo <htejun@gmail.com>]

Alan Cox wrote:
>>> Looks as sane an approach. Some obvious errors in the conversion but
>>> simply wrong types I/O v MMIO etc not flaws in the proposal
>> Care to point out?
> 
> I didn't save it but it was things like HPT3x3 seemed to be claiming to
> be MMIO - trivial stuff we can clean up in a merge.

Ah.. I see.  iomap() interface hides ioport/mmio very well and I just
assumed it was mmio as most controllers which map single BAR and use
parts of it for different ports use mmio.  Fixed.

>>> Unfortunately there is one big horror you've left unconverted - the status
>>> address printing in ata_wait_... That is why I ended up going the way I
>>> did.
>> The only thing I can find is DPRINTK in ata_wait_idle() which can and
>> should simply be converted to ata_port_printk("abnormal Status 0x%x\n",
>> status).  After all some controller don't even have Status register (FIS
>> based ones, ahci, sil24).
> 
> That is probably very sensible yes.

Will add this to the series and repost, thanks.

-- 
tejun