From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, liml@rtr.ca
Subject: Re: [PATCH UPDATED] libata: add support for ATA_16 on ATAPI
Date: Wed, 01 Aug 2007 10:00:20 -0400 [thread overview]
Message-ID: <46B091F4.5070704@garzik.org> (raw)
In-Reply-To: <20070801075624.GD13674@htj.dyndns.org>
Tejun Heo wrote:
> From: Mark Lord <liml@rtr.ca>
>
> Add support for issuing ATA_16 passthru commands to ATAPI devices
> managed by libata. It requires the previous CDB length fix patch.
>
> A boot/module parameter, "atapi_scmd85=1" can be used to globally
> disable this feature, if ever desired.
>
> tj: renamed ata16_passthru module param to atapi_scmd85 to reduce
> confusion
>
> tj: restructured __ata_scsi_queuecmd() according to Jeff's suggestion.
>
> Signed-off-by: Mark Lord <liml@rtr.ca>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Jeff, Mark, are you guys okay with the modified version?
Close! Thanks for revising!
My only comment now is that I dislike atapi_scmd85. That means nothing
to me.
I liked the old name better. Or maybe use atapi_passthru16.
Jeff
next prev parent reply other threads:[~2007-08-01 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 7:56 [PATCH UPDATED] libata: add support for ATA_16 on ATAPI Tejun Heo
2007-08-01 14:00 ` Jeff Garzik [this message]
2007-08-01 14:11 ` Tejun Heo
2007-08-02 12:01 ` Mark Lord
2007-08-07 16:08 ` [PATCH RE-UPDATED] " Tejun Heo
2007-08-15 7:23 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B091F4.5070704@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).