From: Jeff Garzik <jeff@garzik.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_sis: fix MWDMA for <= UDMA66 chipsets and UDMA for UDMA33 chipsets
Date: Wed, 01 Aug 2007 10:02:36 -0400 [thread overview]
Message-ID: <46B0927C.10408@garzik.org> (raw)
In-Reply-To: <200707312202.41856.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * Fix MWDMA timings setup in sis_old_set_dmamode() and sis_66_set_dmamode().
>
> The old timings were overclocked (even worse behavior than sis5513 IDE driver
> which depends on BIOS to program correct timings), the new timings are taken
> from the datasheet (they match timings from ATA spec).
>
> * Fix UDMA timings setup in sis_old_set_dmamode().
>
> Misplaced pci_write_config_word() call resulted in UDMA timings never
> being set.
>
> * Fix comments for sis_133_early_set_dmamode() and sis_133_set_dmamode():
> - only the former function handles early SiS 961 bridges
> - both functions lack MWDMA timings setup
>
> * Fix typos in sis_100_set_piomode() and sis_133_set_piomode() comments.
>
> * Bump driver version.
>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> Sergei: Yes, I'm working on sis5513 IDE driver. :)
>
> drivers/ata/pata_sis.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
applied to #upstream-fixes
prev parent reply other threads:[~2007-08-01 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 20:02 [PATCH] pata_sis: fix MWDMA for <= UDMA66 chipsets and UDMA for UDMA33 chipsets Bartlomiej Zolnierkiewicz
2007-08-01 14:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B0927C.10408@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).