Re: Boot fails on Intel SATA controller

[Tejun Heo <htejun@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

Quel Qun wrote:
>  -------------- Original message ----------------------
> From: Tejun Heo <htejun@gmail.com>
>> Hello,
>>
>> Luiz Fernando N. Capitulino wrote:
>>>  Hi there,
>>>
>>>  A Mandriva user is reporting that his machine hangs while booting
>>> kernels 2.6.22.1 and 2.6.23-rc1.
>>>
>>>  But boots fine with 2.6.21.
>>>
>>> ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
>>> ata1.00: qc timeout (cmd 0x27)
>>> ata1.00: ata_hpa_resize 1: hpa sectors (0) is smaller than sectors (781422768)
>>> ata1.00: ATA-7: HDS724040KLSA80, KFAOA20N, max UDMA/133
>>> ata1.00: 781422768 sectors, multi 8: LBA48
>>> ata1.00: failed to set xfermode (err_mask=0x40)
>>> ata1: failed to recover some devices, retrying in 5 secs
>> What happens after this?
>>
> It basically retries a few times, then fails to boot. Here is a more complete log with 2.6.23-rc1:

Does the attached patch change anything?

-- 
tejun

[-- Attachment #2: debug.patch --]
[-- Type: text/x-patch, Size: 522 bytes --]

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index d8c6789..af5db69 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1915,8 +1915,8 @@ int ata_dev_configure(struct ata_device *dev)
 					dev->flags |= ATA_DFLAG_FLUSH_EXT;
 			}
 
-			if (ata_id_hpa_enabled(dev->id))
-				dev->n_sectors = ata_hpa_resize(dev);
+			//if (ata_id_hpa_enabled(dev->id))
+			//	dev->n_sectors = ata_hpa_resize(dev);
 
 			/* config NCQ */
 			ata_dev_config_ncq(dev, ncq_desc, sizeof(ncq_desc));