linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Quel Qun <kelk1@comcast.net>
Cc: "Luiz Luiz Fernando N. Capitulino"
	<lcapitulino@mandriva.com.br>"linux-ide@vger.kernel.orgFernando
	N. Capitulino"
	<lcapitulino@mandriva.com.br>linux-ide@vger.kernel.org
Subject: Re: Boot fails on Intel SATA controller
Date: Sat, 04 Aug 2007 16:40:26 +0900	[thread overview]
Message-ID: <46B42D6A.7030408@gmail.com> (raw)
In-Reply-To: <080320071730.15251.46B3662E0002B87600003B932207020853CE05040A05@comcast.net>

[-- Attachment #1: Type: text/plain, Size: 43 bytes --]

Please test the attached patch.

-- 
tejun

[-- Attachment #2: horkage-hpa.patch --]
[-- Type: text/x-patch, Size: 1333 bytes --]

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 60e78be..7158a06 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1911,7 +1911,8 @@ int ata_dev_configure(struct ata_device *dev)
 					dev->flags |= ATA_DFLAG_FLUSH_EXT;
 			}
 
-			if (ata_id_hpa_enabled(dev->id))
+			if (!(dev->horkage & ATA_HORKAGE_BROKEN_HPA) &&
+			    ata_id_has_hpa(id) && ata_id_hpa_enabled(dev->id))
 				dev->n_sectors = ata_hpa_resize(dev);
 
 			/* config NCQ */
@@ -3789,6 +3790,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "FUJITSU MHV2080BH",	"00840028",	ATA_HORKAGE_NONCQ, },
 	{ "ST9160821AS",	"3.CLF",	ATA_HORKAGE_NONCQ, },
 	{ "SAMSUNG HD401LJ",	"ZZ100-15",	ATA_HORKAGE_NONCQ, },
+	{ "HDS724040KLSA80",	"KFAOA20N",	ATA_HORKAGE_BROKEN_HPA, },
 
 	/* Devices with NCQ limits */
 
diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 41978a5..a67bb90 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -303,6 +303,7 @@ enum {
 	ATA_HORKAGE_NODMA	= (1 << 1),	/* DMA problems */
 	ATA_HORKAGE_NONCQ	= (1 << 2),	/* Don't use NCQ */
 	ATA_HORKAGE_MAX_SEC_128	= (1 << 3),	/* Limit max sects to 128 */
+	ATA_HORKAGE_BROKEN_HPA	= (1 << 4),	/* Broken HPA */
 };
 
 enum hsm_task_states {

       reply	other threads:[~2007-08-04  7:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <080320071730.15251.46B3662E0002B87600003B932207020853CE05040A05@comcast.net>
2007-08-04  7:40 ` Tejun Heo [this message]
2007-08-06 19:17 Boot fails on Intel SATA controller Quel Qun
2007-08-06 20:03 ` Luiz Fernando N. Capitulino
  -- strict thread matches above, loose matches on Subject: below --
2007-08-02 16:49 Quel Qun
2007-08-03 11:00 ` Tejun Heo
2007-08-01 14:18 Quel Qun
2007-08-01 14:36 ` Tejun Heo
2007-08-01 14:39   ` Luiz Fernando N. Capitulino
2007-07-31 14:00 Luiz Fernando N. Capitulino
2007-08-01  6:06 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B42D6A.7030408@gmail.com \
    --to=htejun@gmail.com \
    --cc=kelk1@comcast.net \
    --cc=lcapitulino@mandriva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).