Re: [PATCH 6/11] ide: remove ide_use_fast_pio()

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Bartlomiej Zolnierkiewicz wrote:

> Remove ide_use_fast_pio() and just re-tune PIO unconditionally if DMA tuning
> has failed in ->ide_dma_check.  All host drivers using ide_use_fast_pio() set
> drive->autotune so PIO is always tuned anyway and in some cases we _really_
> need to re-tune PIO because PIO and DMA timings are shared.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: b/drivers/ide/ide-lib.c
> ===================================================================
> --- a/drivers/ide/ide-lib.c
> +++ b/drivers/ide/ide-lib.c
> @@ -96,21 +96,6 @@ static u8 ide_rate_filter(ide_drive_t *d
>  	return min(speed, mode);
>  }
>  
> -int ide_use_fast_pio(ide_drive_t *drive)
> -{
> -	struct hd_driveid *id = drive->id;
> -
> -	if ((id->capability & 1) && drive->autodma)
> -		return 1;
> -
> -	if ((id->capability & 8) || (id->field_valid & 2))
> -		return 1;

    This reminds me to some time actually fix handling of pre-EIDE drives in 
ide_config_drive_speed()... :-)

MBR, Sergei