From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/3] aec62xx: always tune PIO
Date: Mon, 06 Aug 2007 20:16:49 +0400 [thread overview]
Message-ID: <46B74971.6080500@ru.mvista.com> (raw)
In-Reply-To: <200708012239.44013.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/pci/aec62xx.c
> ===================================================================
> --- a/drivers/ide/pci/aec62xx.c
> +++ b/drivers/ide/pci/aec62xx.c
> @@ -1,5 +1,5 @@
> /*
> - * linux/drivers/ide/pci/aec62xx.c Version 0.24 May 24, 2007
> + * linux/drivers/ide/pci/aec62xx.c Version 0.25 Aug 1, 2007
> *
> * Copyright (C) 1999-2002 Andre Hedrick <andre@linux-ide.org>
> * Copyright (C) 2007 MontaVista Software, Inc. <source@mvista.com>
> @@ -207,10 +207,10 @@ static void __devinit init_hwif_aec62xx(
> } else
> hwif->set_dma_mode = &aec6260_set_mode;
>
> - if (!hwif->dma_base) {
> - hwif->drives[0].autotune = hwif->drives[1].autotune = 1;
> + hwif->drives[0].autotune = hwif->drives[1].autotune = 1;
> +
> + if (hwif->dma_base == 0)
> return;
> - }
>
> hwif->ultra_mask = hwif->cds->udma_mask;
> hwif->mwdma_mask = 0x07;
Ugh, I really need to complete the patch de-uglifying the speedproc()
methods in this driver...
MBR, Sergei
prev parent reply other threads:[~2007-08-06 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 20:39 [PATCH 3/3] aec62xx: always tune PIO Bartlomiej Zolnierkiewicz
2007-08-06 16:16 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B74971.6080500@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).