From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
linux-ide@vger.kernel.org, rah@bash.sh
Subject: Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL
Date: Tue, 07 Aug 2007 21:22:21 -0400 [thread overview]
Message-ID: <46B91ACD.2000104@garzik.org> (raw)
In-Reply-To: <20070808021703.77114775@the-village.bc.nu>
Alan Cox wrote:
> On Tue, 07 Aug 2007 20:49:34 -0400
> Jeff Garzik <jeff@garzik.org> wrote:
>
>> Alan Cox wrote:
>>>> /* Compute DPLL */
>>>> - dpll = 2;
>>>> - if (port->udma_mask & 0xE0)
>>>> - dpll = 3;
>>>> + dpll = (port->udma_mask & 0xC0) ? 3 : 2;
>>> Gak, I'd much rather people kept to the nice easy to read if() but fine
>>>
>>> is_author_p()?Signed-off-by:Acked-by Alan Cox <alan@redhat.com>
>> Does your ACK stand, even though it still locks up for Bob Ham?
>
>
> Its a real fix for a real bug. The 374 needs a bit more stuff which is
> sitting in my tree and I'll push for Sergei to comment tomorrow
OK, thanks. Do you also ACK
[PATCH 2/2] pata_hpt{37x|3x2n}: fix clock reporting
?
Jeff
next prev parent reply other threads:[~2007-08-08 1:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 18:45 [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL Sergei Shtylyov
2007-08-05 19:23 ` Alan Cox
2007-08-08 0:49 ` Jeff Garzik
2007-08-08 1:17 ` Alan Cox
2007-08-08 1:22 ` Jeff Garzik [this message]
2007-08-08 1:41 ` Alan Cox
2007-08-06 16:53 ` Bob Ham
2007-08-06 17:16 ` Sergei Shtylyov
2007-08-09 20:48 ` Bartlomiej Zolnierkiewicz
2007-08-09 22:52 ` Alan Cox
2007-08-09 23:52 ` Bartlomiej Zolnierkiewicz
2007-08-10 13:24 ` Alan Cox
2007-08-10 15:39 ` Sergei Shtylyov
2007-08-10 15:36 ` Sergei Shtylyov
2007-08-10 15:34 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B91ACD.2000104@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=rah@bash.sh \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).