From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: libata git tree, mbox queue status and contents Date: Wed, 08 Aug 2007 10:42:22 -0400 Message-ID: <46B9D64E.6070609@rtr.ca> References: <46B35344.3090208@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([64.26.128.89]:3698 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764900AbXHHOmZ (ORCPT ); Wed, 8 Aug 2007 10:42:25 -0400 In-Reply-To: <46B35344.3090208@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: IDE/ATA development list , Linux Kernel Mailing List , Andrew Morton , Alan Jeff, This patch (below) is needed by WD drives that powerup-in-standby. Cheers Mark -------- Original Message -------- Subject: + libata-adjust-libata-to-ignore-errors-after.patch added to -mm tree Date: Wed, 18 Jul 2007 17:03:29 -0700 From: akpm@linux-foundation.org To: mm-commits@vger.kernel.org CC: rpower@sysreset.com, htejun@gmail.com, jeff@garzik.org, liml@rtr.ca The patch titled libata: adjust libata to ignore errors after spinup has been added to the -mm tree. Its filename is libata-adjust-libata-to-ignore-errors-after.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: libata: adjust libata to ignore errors after spinup From: Ryan Power Adjust libata to ignore errors after spinup This patch is to ignore errors from the spinup attempt if the drive is in the "standby id" state. Signed-off-by: Ryan Power Acked-by: Mark Lord Cc: Jeff Garzik Cc: Tejun Heo Signed-off-by: Andrew Morton --- drivers/ata/libata-core.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN /dev/null /dev/null diff -puN drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after drivers/ata/libata-core.c --- a/drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after +++ a/drivers/ata/libata-core.c @@ -1723,7 +1723,7 @@ int ata_dev_read_id(struct ata_device *d tf.protocol = ATA_PROT_NODATA; tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE; err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0); - if (err_mask) { + if (err_mask && id[2] != 0x738c) { rc = -EIO; reason = "SPINUP failed"; goto err_out; _ Patches currently in -mm which might be from rpower@sysreset.com are libata-adjust-libata-to-ignore-errors-after.patch